Skip to content

Promote Immutable Secrets/ConfigMaps feature to GA#2179

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
wojtek-t:immutable_secrets_ga
Jan 5, 2021
Merged

Promote Immutable Secrets/ConfigMaps feature to GA#2179
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
wojtek-t:immutable_secrets_ga

Conversation

@wojtek-t
Copy link
Copy Markdown
Member

@wojtek-t wojtek-t commented Dec 10, 2020

/assign @johnbelamaric - for PRR approval
/assign @msau42 @saad-ali - for SIG storage approval

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 10, 2020

@wojtek-t: GitHub didn't allow me to assign the following users: approval, -, for, SIG, storage.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @johnbelamaric - for PRR approval
/assign @msau42 @saad-ali - for SIG storage approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 10, 2020
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Dec 10, 2020
@wojtek-t
Copy link
Copy Markdown
Member Author

wojtek-t commented Dec 10, 2020

/hold

[To ensure that it won't accidentaly merge without both PRR and SIG-storage approval.]

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2020
@wojtek-t wojtek-t force-pushed the immutable_secrets_ga branch from 4a09a9e to ad350ab Compare December 22, 2020 11:05
@johnbelamaric
Copy link
Copy Markdown
Member

johnbelamaric commented Dec 22, 2020

/retest

@johnbelamaric
Copy link
Copy Markdown
Member

johnbelamaric commented Dec 23, 2020

PRR is approved - I am not using the command because it will approve the whole PR.

@wojtek-t wojtek-t mentioned this pull request Dec 30, 2020
Merged
@msau42
Copy link
Copy Markdown
Member

msau42 commented Jan 5, 2021

/approve

@msau42
Copy link
Copy Markdown
Member

msau42 commented Jan 5, 2021

/lgtm

@msau42
Copy link
Copy Markdown
Member

msau42 commented Jan 5, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 5, 2021
@saad-ali
Copy link
Copy Markdown
Member

saad-ali commented Jan 5, 2021

/lgtm
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, saad-ali, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ac2ede1 into kubernetes:master Jan 5, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 5, 2021
@xing-yang xing-yang mentioned this pull request Jan 6, 2021
Closed
@cupnes cupnes mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saad-ali saad-ali Awaiting requested review from saad-ali

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@johnbelamaric johnbelamaric

@saad-ali saad-ali

@msau42 msau42

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.21

Development

Successfully merging this pull request may close these issues.

5 participants

@wojtek-t @k8s-ci-robot @johnbelamaric @msau42 @saad-ali