Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retroactive KEP-266: Kubelet client certificate bootstrap/rotation #1756

Merged
merged 3 commits into from
May 14, 2020

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented May 8, 2020

Convert community proposal to KEP format, add additional KEP sections (test plan, skew considerations, graduation criteria)

The feature was implemented in the 1.4-1.8 timeframe, stabilized in the 1.8-1.11 timeframe, and has been waiting in beta status for the CSR API to graduate to v1.

This KEP is primarily to document the design of the already-implemented feature, and establish graduation criteria for flipping the feature gate from Beta to GA in 1.19.

/sig auth node
/cc @mikedanese @smarterclayton @johnbelamaric

@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 8, 2020
@liggitt liggitt force-pushed the kubelet-cert branch 2 times, most recently from 09f8f81 to a4078af Compare May 8, 2020 18:06
@liggitt liggitt added this to the v1.19 milestone May 8, 2020
@liggitt liggitt changed the title KEP-266: Kubelet client certificate bootstrap/rotation Retroactive KEP-266: Kubelet client certificate bootstrap/rotation May 8, 2020
@liggitt
Copy link
Member Author

liggitt commented May 14, 2020

/assign @johnbelamaric
for PRR questionnaire

@liggitt liggitt force-pushed the kubelet-cert branch 2 times, most recently from e58bc02 to 64ad8bc Compare May 14, 2020 21:26
@liggitt
Copy link
Member Author

liggitt commented May 14, 2020

addressed @smarterclayton's comments, updated with production readiness questions and added @johnbelamaric

@johnbelamaric
Copy link
Member

/approve for PRR, nicely done Jordan

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mikedanese
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit c6d1db3 into kubernetes:master May 14, 2020
@liggitt liggitt deleted the kubelet-cert branch July 6, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants