Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate additional fields - owning-sig and participating-sigs #1468

Merged
merged 8 commits into from
Jan 19, 2020
Merged

Validate additional fields - owning-sig and participating-sigs #1468

merged 8 commits into from
Jan 19, 2020

Conversation

dims
Copy link
Member

@dims dims commented Jan 19, 2020

fetch the "correct" list from https://raw.githubusercontent.com/kubernetes/community/master/sigs.yaml and validate the fields using that list.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/provider/aws Issues or PRs related to aws provider area/provider/azure Issues or PRs related to azure provider kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/pm sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Jan 19, 2020
@dims
Copy link
Member Author

dims commented Jan 19, 2020

/assign @justaugustus @calebamiles @jdumars

justaugustus
justaugustus requested changes Jan 19, 2020
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tightening this up, @dims!
Left a few comments.

/hold

keps/0001-kubernetes-enhancement-proposal-process.md Outdated
@@ -4,8 +4,6 @@ authors:
- "@calebamiles"
- "@jbeda"
owning-sig: sig-architecture
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
owning-sig: sig-architecture
owning-sig: sig-pm

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE

keps/0001-kubernetes-enhancement-proposal-process.md
@@ -4,8 +4,6 @@ authors:
- "@calebamiles"
- "@jbeda"
owning-sig: sig-architecture
participating-sigs:
- kubernetes-wide
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point, we probably want to reintroduce this idea?
Maybe something like scope: group|project?

Copy link
Member Author

@dims dims Jan 19, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we should. let's leave it out for now (out of this PR)

keps/sig-release/k8s-image-promoter.md
@@ -4,7 +4,7 @@ authors:
- "@javier-b-perez"
owning-sig: sig-release
participating-sigs:
- TBD
- wg-k8s-infra
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels odd, given that wg-k8s-infra is not a SIG.
Can we maybe go for participating or participating-groups instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't want to change the key here in this PR, we should do a follow up to rename

pkg/kepval/keps/validations/yaml.go Outdated
@@ -71,7 +86,34 @@ func (m *MustHaveAtLeastOneValue) Error() string {
return fmt.Sprintf("%q must have at least one value", m.key)
}

var listSIGsAndWGs []string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var listSIGsAndWGs []string
var listGroups []string

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2020
@justaugustus justaugustus added this to the keps-beta milestone Jan 19, 2020
@justaugustus justaugustus mentioned this pull request Jan 19, 2020
Closed
7 tasks
@justaugustus
Copy link
Member

@dims -- Added the suggestions to #822 (comment). Thanks for this!
/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1d46c68 into kubernetes:master Jan 19, 2020
@k8s-ci-robot k8s-ci-robot modified the milestones: keps-beta, v1.18 Jan 19, 2020
@justaugustus justaugustus added area/enhancements Issues or PRs related to the Enhancements subproject and removed sig/pm labels Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus requested changes

@ahg-g ahg-g Awaiting requested review from ahg-g

@cheftako cheftako Awaiting requested review from cheftako

Assignees

@justaugustus justaugustus

@calebamiles calebamiles

@jdumars jdumars

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/enhancements Issues or PRs related to the Enhancements subproject area/provider/aws Issues or PRs related to aws provider area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
5 participants
@dims @justaugustus @k8s-ci-robot @calebamiles @jdumars