Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inter-pod affinity to more than one pod #623

Closed
bsalamat opened this issue Oct 1, 2018 · 16 comments
Closed

Add inter-pod affinity to more than one pod #623

bsalamat opened this issue Oct 1, 2018 · 16 comments
Assignees
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@bsalamat
Copy link
Member

bsalamat commented Oct 1, 2018

Feature Description

  • One-line feature description (can be used as a release note): Currently, a single pod must satisfy all inter-pod affinity terms of an incoming pod before the incoming pod is considered schedulable. We want to expand this to support multiple pods matching multiple affinity terms of an incoming pod.
  • Primary contact (assignee): @bsalamat, @Huang-Wei
  • Responsible SIGs: scheduling
  • Design proposal link (community repo): Support inter-Pod affinity to one or more Pods kubernetes#68701
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @bsalamat @k82cn
  • Approver (likely from SIG/area to which feature belongs): @bsalamat
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y) 1.13
    • Stable release target (x.y)
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 1, 2018
@kacole2
Copy link

kacole2 commented Oct 1, 2018

this has been added to the tracking sheet for 1.13

/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Oct 1, 2018
@Huang-Wei
Copy link
Member

/sig scheduling

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 2, 2018
@kacole2 kacole2 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Oct 8, 2018
@AishSundar
Copy link

@bsalamat @Huang-Wei do we have an active assignee / owner for this feature. is this actively being targeted in 1.13? can we plz fill int he following labels - stage, kind

Also do we have a list of PRs or issues we are tracking for this feature? thanks

@Huang-Wei
Copy link
Member

/assign @Huang-Wei @bsalamat

I'm not 100% sure we can target in 1.13. We've recently done several rounds of re-design, latest version looks good, but still needs to take a close look at both correctness and performance.

Right now I'd say 50-50, we should be able to give a final decision at early Nov.

@AishSundar
Copy link

What stage is this feature getting into 1.13? Alpha? 1.13 is currently targeted to be a stability themed release where we focus on finishing and landing deferred features from previous releases, bug fixes that improve the stability of existing features and/or test improvements. If this is a net new feature that is still in design and experimentation phase, I strongly recommend this wait until 1.14. This cycle is as such super short and aggressive with code freeze set for 11/15.

@spiffxp @kacole2

@bsalamat
Copy link
Member Author

Given that 1.13 is stability release, it makes sense to move this to 1.14. WDYT @Huang-Wei?

@Huang-Wei
Copy link
Member

@bsalamat I'm fine with postponing to 1.14.

@kacole2
Copy link

kacole2 commented Oct 18, 2018

thanks folks!
/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.13 milestone Oct 18, 2018
@kacole2 kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Oct 18, 2018
@kacole2 kacole2 added this to the v1.14 milestone Oct 18, 2018
@claurence
Copy link

@bsalamat Hello - I’m the enhancement’s lead for 1.14 and I’m checking in on this issue to see what work (if any) is being planned for the 1.14 release. Enhancements freeze is Jan 29th and I want to remind that all enhancements must have a KEP - I can't find a KEP for this issue can you please link the relevant KEP? Thanks!

@claurence
Copy link

@bsalamat since there is no KEP for this issue yet we will be removing it from the 1.14 milestone. To have it added back in please file an exception - information on the exception process can be found here: https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

@claurence claurence removed this from the v1.14 milestone Jan 30, 2019
@kacole2
Copy link

kacole2 commented Apr 12, 2019

Hello @bsalamat , I don't see a KEP so it can't be added to the milestone until that is complete.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 11, 2019
@evillgenius75
Copy link

Hi @bsalamat , I'm the 1.16 Enhancement Shadow. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. Currently this enhancement is set to stale

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

I do not see a link to a KEP, as a reminder, every enhancement requires a KEP in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 10, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests

8 participants