Asynchronous preemption in the scheduler

[sanposhiho]

Enhancement Description

• One-line enhancement description (can be used as a release note): The scheduler runs the preemption (PostFilter) asynchronously to enhance the scheduling throughput on the failure scenarios.
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-scheduling/4832-async-preemption/README.md
• Discussion Link: Run scheduler PostFilters asynchronously to improve throughput kubernetes#126858
• Primary contact (assignee): @sanposhiho
• Responsible SIGs: SIG-Scheduling
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): v1.32
  • Beta release target (x.y):
  • Stable release target (x.y):
• Alpha
  • KEP (k/enhancements) update PR(s): KEP-4832: Asynchronous preemption in the scheduler #4833
  • Code (k/k) update PR(s): feature(KEP-4832): asynchronous preemption kubernetes#128170
  • Docs (k/website) update PR(s): KEP-4832: add SchedulerAsyncPreemption to the doc website#48407

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

/sig scheduling
/assign

[alculquicondor]

/label lead-opted-in

[impact-maker]

Hello @sanposhiho @alculquicondor 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage alpha for v1.32 (correct me, if otherwise).

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: v1.32.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday, October 3rd, 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

• KEP has a production readiness review that has been completed and merged into k/enhancements.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

[tjons]

Hello 👋, v1.32 Enhancements team here.

Unfortunately, this enhancement did not meet requirements for enhancements freeze.

If you still wish to progress this enhancement in v1.32, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks!

[tjons]

/milestone clear

[sanposhiho]

@alculquicondor
Looks like we just missed the deadline.
I believe we can make an exception request because we only need an approval for PRR, and actually @/wojtek-t already mentioned it's generally OK for alpha. What do you think?

[sanposhiho]

I filed an exception request for it. cc @wojtek-t.

[sreeram-venkitesh]

/stage alpha

[tjons]

With all the requirements met, this enhancement's exception is granted and this enhancement is now tracked for enhancements freeze!

[chanieljdan]

Hi @sanposhiho 👋, 1.32 Release Docs Lead here.

Does this enhancement work planned for 1.32 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

[chanieljdan]

Hi @sanposhiho 👋, 1.32 Release Docs Lead here.

Does this enhancement work planned for 1.32 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

Hi @sanposhiho 👋,

Just a reminder to open a placeholder PR against dev-1.32 branch in the k/website repo for this (steps available here). The deadline for this is a week away at Thursday October 24, 2024 18:00 PDT.

Thanks,

Daniel

[sanposhiho]

Created: kubernetes/website#48407

[wrkode]

👋 Hi there, William here from v1.32 Comms
We'd love for you to consider writing a feature blog about your enhancement! Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

[sanposhiho]

I believe we don't need a blog post for this. (at least, within this release)

[wrkode]

Thank's for your prompt feedback @sanposhiho

[tjons]

Hey again @sanposhiho 👋 v1.32 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Friday 8th November 2024 / 19:00 PDT Thursday 7th November 2024 .

Here's where this enhancement currently stands:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP):

• [Umbrella] KEP-4832(alpha): Asynchronous preemption alpha requirement kubernetes#128014
• KEP-4832(alpha): The core implementation change in the preemption plugin, along with the feature gate kubernetes#128020

Additionally, please let me know if there are any other PRs in k/k not listed in the description or not linked with this GitHub issue that we should track for this KEP, so that we can maintain accurate status.

The status of this enhancement is marked as at risk for code freeze.

If you anticipate missing code freeze, you can file an exception request in advance. Thank you!

[tjons]

Hello @sanposhiho 👋, Enhancements team here.

With all the implementation (code related) PRs merged as per the issue description:

• KEP-4832(alpha): The core implementation change in the preemption plugin, along with the feature gate kubernetes#128020

This enhancement is now marked as tracked for code freeze for the 1.32 Code Freeze!

Please note that KEPs targeting stable need to have the status field marked as implemented in the kep.yaml file after code PRs are merged and the feature gates are removed.

[sanposhiho]

@alculquicondor Can we include it within this release cycle as well? or would you suggest not?

[dipesh-rawat]

Hello @sanposhiho 👋, 1.33 Enhancements Lead here.

If you'd like to work on this enhancement in v1.33, please have the SIG lead opt-in by adding the lead-opted-in label, which ensures it gets added to the tracking board. Also, please set the milestone to v1.33 using /milestone v1.33.
Thanks!

/remove-label lead-opted-in

[alculquicondor]

You mean graduate to beta? I don't see why not.

[alculquicondor]

cc @macsko @dom4ha any viewpoints?

[sanposhiho]

Graduate to beta as it is, or potentially update KEP with kubernetes/kubernetes#129449 if we discuss and decide to do that.

[dom4ha]

Not sure for how long we usually wait to spot potential issues, so not certain what to suggest here.

As a side note, the preemption process itself has a few important issues. One of them is the performance, which async preemption helps to mitigate, so it's an argument for moving forward.

However, the current process cannot preempt pods running on a different node than the candidate wants to schedule. I'm looking into this issue and I hope we will be able to do some brainstorming soon how it could be addressed as well. Once we do that, maybe we;d have more clear picture what actions we should take and when.

[sanposhiho]

We have a plugin for that as a subproject.
https://github.com/kubernetes-sigs/scheduler-plugins/blob/master/pkg%2Fcrossnodepreemption%2FREADME.md

We can consider implementing the same if there's many-enough people wanting it. But, I'm not sure if we're getting such feedback from various folks.

[dom4ha]

Thanks Kensei for the pointer. IIUC the plugin tries the brute force approach, which would impact performance a lot, so I'd think about something more performance oriented.

Regarding the interest, I suspect that development around DRA and other more complex dependencies, will force us to look closer into this problem.

[dom4ha]

@sanposhiho Is there also an issue describing the problem and considered solutions?

[sanposhiho]

cc @Huang-Wei, might know more context for the plugin.

I'd think about something more performance oriented

Nice, I didn't grasp its algorithm actually.
It would be great to make an improvement in the algorithm, regardless of whether we decide to or not to move it to the upstream.

I suspect that development around DRA and other more complex dependencies, will force us to look closer into this problem.
...
Is there also an issue describing the problem and considered solutions?

DRA has its own PostFilter and hence I'm not sure if they really would.
But, feel free to create an issue for the discussion. (AFAIK, we don't have an issue) Either way, here isn't an appropriate place to continue this discussion.
We can discuss the solution, whether we need to implement it within the upstream scheduler, etc.

[alculquicondor]

Can we move discussions about cross-node preemption to a separate issue? It's not related to this enhancement.

In the meantime, I'm not hearing anything against moving to beta.

/label lead-opted-in

[ArkaSaha30]

Hello @sanposhiho 👋, v1.33 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025.

This enhancement is targeting stage beta for v1.33 (correct me, if otherwise)
/stage beta

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone: v1.33.
• KEP readme has up-to-date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 6th February 2025 so that the PRR team has enough time to review your KEP.

For this KEP, we would just need to update the following:

• KEP needs to be updated with the target release
• Description needs to reflect the correct Beta release target (x.y): v1.33
• KEP needs to be updated with prr-approvers as per PRR yaml

The status of this enhancement is marked as At risk for enhancements freeze. Please keep the issue description up-to-date with appropriate stages as well.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!