Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRA: structured parameters #4381

Open
8 of 12 tasks
pohly opened this issue Jan 4, 2024 · 37 comments
Open
8 of 12 tasks

DRA: structured parameters #4381

pohly opened this issue Jan 4, 2024 · 37 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team wg/batch Categorizes an issue or PR as relevant to WG Batch.
Milestone

Comments

@pohly
Copy link
Contributor

pohly commented Jan 4, 2024

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 4, 2024
@pohly
Copy link
Contributor Author

pohly commented Jan 4, 2024

/sig node
/wg batch

The rationale behind creating a separate KEP is that this is an extension of DRA that (at least in theory) could graduate at its own pace. The KEP document itself also will be shorter, which will make discussing it easier.

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. wg/batch Categorizes an issue or PR as relevant to WG Batch. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 4, 2024
@SergeyKanzhelev
Copy link
Member

/stage alpha
/milestone v1.30

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jan 26, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 26, 2024
@pohly pohly changed the title DRA: numeric parameters DRA: semantic parameters Jan 31, 2024
@klueska
Copy link
Contributor

klueska commented Feb 7, 2024

/milestone v1.30
/label lead-opted-in

@k8s-ci-robot
Copy link
Contributor

@klueska: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.30
/label lead-opted-in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johnbelamaric
Copy link
Member

@SergeyKanzhelev can we get this added to the 1.30 milestone?

@johnbelamaric
Copy link
Member

/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Feb 7, 2024
@k8s-ci-robot
Copy link
Contributor

@klueska: Can not set label lead-opted-in: Must be member in one of these teams: [release-team-enhancements release-team-leads sig-api-machinery-leads sig-apps-leads sig-architecture-leads sig-auth-leads sig-autoscaling-leads sig-cli-leads sig-cloud-provider-leads sig-cluster-lifecycle-leads sig-contributor-experience-leads sig-docs-leads sig-instrumentation-leads sig-k8s-infra-leads sig-multicluster-leads sig-network-leads sig-node-leads sig-release-leads sig-scalability-leads sig-scheduling-leads sig-security-leads sig-storage-leads sig-testing-leads sig-windows-leads]

In response to this:

/milestone v1.30
/label lead-opted-in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SergeyKanzhelev
Copy link
Member

/label lead-opted-in
/milestone v1.30

@salehsedghpour
Copy link
Contributor

Hello @pohly 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 9th February 2024.

This enhancement is targeting for stage alpha for v1.30 (correct me, if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: 1.30.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

For this KEP, we would just want to update the following but it's not required for alpha stage and it will serve for future stages:

The status of this enhancement is marked as At risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well, I couldn't find any related PR regarding this KEP in k/enhancements. Thank you!

@salehsedghpour
Copy link
Contributor

With all the requirements fulfilled this enhancement is now marked as tracked for the upcoming enhancements freeze 🚀

@pohly pohly changed the title DRA: semantic parameters DRA: structured parameters Feb 9, 2024
@drewhagen
Copy link
Member

Hello @pohly 👋, 1.30 Docs Lead here.

Does this enhancement work planned for 1.30 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.30 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday February 22nd 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@fkautz
Copy link
Member

fkautz commented Feb 16, 2024

Hi @pohly

👋 from the v1.30 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!

We encourage blogs for features including, but not limited to: breaking changes, features and changes important to our users, and features that have been in progress for a long time and are graduating.

To opt in, you need to open a Feature Blog placeholder PR against the website repository.
The placeholder PR deadline is 27th February, 2024.
Here's the 1.30 Release Calendar

@pohly
Copy link
Contributor Author

pohly commented Feb 22, 2024

Doc PR for 1.30 created and linked to in the description.

@salehsedghpour
Copy link
Contributor

salehsedghpour commented Feb 23, 2024

Hey again @pohly 👋 Enhancements team here,

Just checking in as we approach code freeze at 02:00 UTC Wednesday 6th March 2024 .

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, I couldn't find any (open) PRs in k/k. With this, it is now marked as at risk for code freeze for the v1.30 Code Freeze!

Please let me know if there are other PRs in k/k we should be tracking for this KEP.
As always, we are here to help if any questions come up. Thanks!

@prianna
Copy link

prianna commented Jun 5, 2024

Hello @pohly 👋, Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

This enhancement is targeting stage alpha for v1.31 (correct me if otherwise)

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.31. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has submitted a production readiness review request for approval and has a reviewer assigned.
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here).

With all the KEP requirements in place and merged into k/enhancements, this enhancement is all good for the upcoming enhancements freeze. 🚀

The status of this enhancement is marked as tracked for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

@hacktivist123
Copy link

Hello @pohly 👋, 1.31 Docs Shadow here.

Does this enhancement work planned for 1.31 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.31 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday June 27, 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarised with the docs requirement for the release.

Thank you!

@pohly
Copy link
Contributor Author

pohly commented Jun 14, 2024

@prianna: I was a bit late with updating the issue description. What you looked at was the KEP update for 1.30, not the one for 1.31. However, the one for 1.31 also got reviewed, approved and merged before the deadline, so the end result is the same. Sorry for the confusion!

@hacktivist123: I created a placeholder PR.

@hacktivist123
Copy link

Thanks for the update @pohly

@rashansmith
Copy link

Hi @pohly,

👋 from the v1.31 Communications Team! We'd love for you to opt in to write a feature blog about your enhancement!
Some reasons why you might want to write a blog for this feature include (but are not limited to) if this introduces breaking changes, is important to our users, or has been in progress for a long time and is graduating.

To opt in, let us know and open a Feature Blog placeholder PR against the website repository by 3rd July, 2024. For more information about writing a blog see the blog contribution guidelines.

Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release.

@sreeram-venkitesh sreeram-venkitesh added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jun 24, 2024
@rashansmith
Copy link

rashansmith commented Jun 28, 2024

Hey @pohly, friendly reminder about the upcoming blog opt-in and placeholder deadline on July 3rd. Please open a blog placeholder PR if you are interested in contributing a blog.

@prianna
Copy link

prianna commented Jul 9, 2024

Hey again @pohly 👋 Enhancements team here,

To avoid repeating myself too much (see #3063), I'll just note the below here as well.

Here's where this enhancement currently stands:

  • All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
  • All PR/s are ready to be merged (they have approved and lgtm labels applied) by the code freeze deadline. This includes tests.

For this enhancement, it looks like the following PRs are open and need to be merged before code freeze:

If you anticipate missing code freeze, you can file an exception request in advance.

@prianna
Copy link

prianna commented Jul 22, 2024

@hacktivist123 Same question here re: the transition to tracked? It doesn't look like this one is ready either.

@sreeram-venkitesh
Copy link
Member

@pohly Is merging kubernetes/kubernetes#125488 related to this KEP? I could only find another PR, kubernetes/kubernetes#120611 related to this KEP. Please let us know if we should be tracking any other PRs as well.

Ref: #3063 (comment)

@pohly
Copy link
Contributor Author

pohly commented Jul 23, 2024

Yes, kubernetes/kubernetes#125488 is also for this KEP and got merged, so we are good for 1.31.

@sreeram-venkitesh
Copy link
Member

Awesome, thanks a lot. Are we good to mark this KEP as tracked for code freeze? I'm also curious to know where kubernetes/kubernetes#120611 comes into picture.

@pohly
Copy link
Contributor Author

pohly commented Jul 23, 2024

kubernetes/kubernetes#120611 is an optional PR for this feature in 1.31. Would be nice to have, but not required.

@sreeram-venkitesh
Copy link
Member

Thanks a lot @pohly! Marking this KEP as tracked for code freeze 🎉

@pohly
Copy link
Contributor Author

pohly commented Aug 21, 2024

The goal is to promote this to beta in 1.32, if possible.

@tjons
Copy link
Contributor

tjons commented Sep 16, 2024

Hi, enhancements lead here - I inadvertently added this to the 1.32 tracking board 😀. Please readd it if you wish to progress this enhancement in 1.32.

/remove-label lead-opted-in

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Sep 16, 2024
@haircommander
Copy link
Contributor

/milestone v1.32
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.31, v1.32 Sep 17, 2024
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 17, 2024
pohly added a commit to pohly/enhancements that referenced this issue Sep 24, 2024
Much of the PRR text that was originally written for "classic DRA" applies also
to "structured parameters". It gets moved from kubernetes#3063 to kubernetes#4381, with some minor
adaptions. The placeholder comments get restored in kubernetes#3063 because further work
on the KEP would be needed to move it forward - if it gets moved forward at all
instead of being abandoned.

The v1beta1 API will be almost identical to the v1alpha3 API, with just some
minor tweaks to fix oversights.

The kubelet gRPC gets bumped with no changes. Nonetheless, drivers should get
updated, which can be done by updating the Go dependencies and optionally
changing the API import.
pohly added a commit to pohly/enhancements that referenced this issue Sep 24, 2024
Much of the PRR text that was originally written for "classic DRA" applies also
to "structured parameters". It gets moved from kubernetes#3063 to kubernetes#4381, with some minor
adaptions. The placeholder comments get restored in kubernetes#3063 because further work
on the KEP would be needed to move it forward - if it gets moved forward at all
instead of being abandoned.

The v1beta1 API will be almost identical to the v1alpha3 API, with just some
minor tweaks to fix oversights.

The kubelet gRPC gets bumped with no changes. Nonetheless, drivers should get
updated, which can be done by updating the Go dependencies and optionally
changing the API import.
@impact-maker
Copy link
Member

Hello @haircommander 👋, v1.32 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage beta for v1.32 (correct me, if otherwise).

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.32.
  • KEP readme has up-to-date graduation criteria.
  • KEP has submitted a production readiness review request for approval and has a reviewer assigned.
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would need to update the following:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.32.
  • KEP readme has up-to-date graduation criteria.
  • KEP has submitted a production readiness review request for approval and has a reviewer assigned.
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team wg/batch Categorizes an issue or PR as relevant to WG Batch.
Projects
Status: Tracked for Code Freeze
Status: At risk for enhancements freeze
Status: Considered for release
Status: Tracked for Doc Freeze
Development

No branches or pull requests