Add gRPC probe to Pod.Spec.Container.{Liveness,Readiness,Startup}Probe

[bowei]

Enhancement Description

Add gRPC probe to Pod.Spec.Container.{Liveness,Readiness,Startup}Probe

• Kubernetes Enhancement Proposal:
  • Text: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/2727-grpc-probe/README.md
  • PR: Add support for gRPC probes to kubelet (KEP-2727) #2728
  • Original PR: [KEP-1665] Add GRPC probe #1667
• Discussion Link: gRPC health probe proposal kubernetes#89797
• Primary contact (assignee): SergeyKanzhelev@ (bowei@, PxyUp@ was original author)
• Responsible SIGs:
  • SIG-NETWORK
  • SIG-NODE
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y): 1.23
  • Beta release target (x.y): 1.24
  • Stable release target (x.y): 1.27
• Alpha
  • KEP (k/enhancements) update PR(s):
  • Code (k/k) update PR(s):
  • Docs (k/website) update PR(s):
• Beta
  • KEP (k/enhancements) update PR(s):
  • Code (k/k) update PR(s):
  • Docs (k/website) update PR(s):
• Stable
  • KEP (k/enhancements) update PR(s):
    • 2727 - promote grpc probes to GA #3807
  • Code (k/k) update PR(s):
    • GRPCContainerProbe is GA kubernetes#116233
  • Docs (k/website) update PR(s):
    • Update gRPC probes docs for GA website#39919

[bowei]

/sig network

[bowei]

/assign

[bowei]

@PxyUp

[bowei]

/sig node

[SergeyKanzhelev]

for the quick reference of the reviewer, currently supported solutions:

• https://github.com/grpc-ecosystem/grpc-health-probe/
• https://kubernetes.io/blog/2018/10/01/health-checking-grpc-servers-on-kubernetes/

This solution is in high demand:

• https://github.com/search?q=grpc_health_probe+extension%3Ayaml

[ehashman]

@bowei can you start filing an exception request if you want this in 1.22? It seems very unlikely this feature will make the deadline of tomorrow given that it has not been opted in to the release, is missing PRR, etc.

[JamesLaverack]

/milestone v1.22
/stage alpha

[JamesLaverack]

Hi @bowei, 1.22 Enhancements Lead here. We're not removing this from 1.22, but can you address John's comment about updating your kep.yaml metadata to match your KEP README?

[yuzhiquan]

/cc

[bowei]

Got it, updating.

[bowei]

@ehashman do we need an exception request?

[SergeyKanzhelev]

@ehashman do we need an exception request?

It is in the tracking document: https://docs.google.com/spreadsheets/d/1mlui0brYypOAsgS2D13fvcs3At1uMq4i1gWfneq-jxY/edit#gid=1954476102 and was merged in time. Also @ehashman counted it in the Slack message =).

We generally not encouraging last minute KEPs so we have a proper planning and be respectful for reviewers time. I think this one is not controversial and it is great that it got merged in time.

[PxyUp]

@bowei thanks for leading that, sadly i haven't time to finish my proposal. I did MR for prober long time ago may be commits will be also useful:

kubernetes/kubernetes#89832

If you need it, i will rebase and update MR

[yuzhiquan]

@bowei do you working on this now?

If not, i would like to take this from here, and base on @PxyUp work kubernetes/kubernetes#89832.

[marosset]

Hi @bowei 👋,

Checking in as we approach 1.27 code freeze at 17:00 PDT on Tuesday 14th March 2023.

Please ensure the following items are completed:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PRs are fully merged by the code freeze deadline.

Please let me know if there are any other PRs in k/k I should be tracking for this KEP.
I do see a few open issues associated with this KEP and am not sure how to track these.

As always, we are here to help should questions come up. Thanks!

[Rishit-dagli]

Hi @bowei 👋, I’m reaching out from the 1.27 Release Docs team. This enhancement is marked as ‘Needs Docs’ for the 1.27 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.27 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by March 16. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.
Please feel free to reach out with any questions. Thanks!

[bowei]

Thanks, let me take a look.

[SergeyKanzhelev]

kubernetes/website#39919

/assign
/unassign @bowei

@bowei, no worries, I will handle this

[bowei]

Thanks!

[thockin]

NEXT: Remove gate in 1.29

[pacoxu]

This feature is GAed. There are still several issues to track related tasks or in-discussion issues.

• feature request: Add TLS option for grpc probes kubernetes#119093
• test: Write the stress test for gRPC, http, and tcp probes kubernetes#115782
• documentation: gRPC probe semantics prevent their usage for both readiness and liveness kubernetes#115651

[salehsedghpour]

/remove-label lead-opted-in