Skip to content

Commit

Permalink
node: topologymgr: address PRR review comments (2)
Browse files Browse the repository at this point in the history
Signed-off-by: Swati Sehgal <[email protected]>
  • Loading branch information
swatisehgal committed Feb 8, 2023
1 parent 82138a4 commit f6998b4
Showing 1 changed file with 12 additions and 10 deletions.
22 changes: 12 additions & 10 deletions keps/sig-node/693-topology-manager/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -710,7 +710,7 @@ This feature is kubelet specific, so version skew strategy is N/A.

- [X] Feature gate (also fill in values in `kep.yaml`)
- Feature gate name: TopologyManager
- Components depending on the feature gate: Topology Manager
- Components depending on the feature gate: kubelet

Kubelet Flag for the Topology Manager Policy, which is described above. The `none` policy will be the default policy.

Expand Down Expand Up @@ -743,15 +743,7 @@ Memory Manager and Device Manager to either admit a pod to the node or reject it

###### Can the feature be disabled once it has been enabled (i.e. can we roll back the enablement)?

Yes, this feature can be disabled by specifying `TopologyManager` feature gate
in the kubelet configuration. Note that disabling the feature gate requires
kubelet restart for the changes to take effect. In case no pods consuming
resources aligned by Topology Manager are running on the node, disabling
feature gate won't cause any issue.

If the feature gate is being disabled on a node where such pods are running,
it is the responsibliity of the cluster admin to ensure that the node is
appropriately drained.
Since going to stable in 1.27, the feature gate is locked on as is the standard practice in Kubernetes.

###### What happens if we reenable the feature if it was previously rolled back?

Expand Down Expand Up @@ -816,6 +808,9 @@ configured.
"topology_manager_admission_duration_seconds" (which will be added as this release) can be used to determine
if the resource alignment logic performed at pod admission time is taking longer than expected.

Measurements haven't been performed to determine the latency as this metric will be introduced in 1.27
development cycle but the duration is expected to be very short most likely in the ballpark of 50-100 ms.

###### What are the SLIs (Service Level Indicators) an operator can use to determine the health of the service?

- [X] Metrics
Expand Down Expand Up @@ -871,6 +866,13 @@ Also, the resource alignment logic is executed at pod admission time which is pr

No reported or known increase in resource usage.

###### Can enabling / using this feature result in resource exhaustion of some node resources (PIDs, sockets, inodes, etc.)?

No.

The feature is only responsble for alignment of resources. It does not use node resources like PIDs, sockets, inodes, etc.
for running its alignment algorithm.

### Troubleshooting

###### How does this feature react if the API server and/or etcd is unavailable?
Expand Down

0 comments on commit f6998b4

Please sign in to comment.