Skip to content

Commit

Permalink
KEP-127: Update TOC
Browse files Browse the repository at this point in the history
Signed-off-by: Rodrigo Campos <[email protected]>
  • Loading branch information
rata committed Feb 2, 2023
1 parent 3c82d9a commit dd330b3
Showing 1 changed file with 13 additions and 11 deletions.
24 changes: 13 additions & 11 deletions keps/sig-node/127-user-namespaces/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,13 @@
- [Design Details](#design-details)
- [Pod.spec changes](#podspec-changes)
- [CRI changes](#cri-changes)
- [Phases](#phases)
- [Phase 1: pods &quot;without&quot; volumes](#phase-1-pods-without-volumes)
- [pkg/volume changes for phase I](#pkgvolume-changes-for-phase-i)
- [Phase 2: pods with volumes](#phase-2-pods-with-volumes)
- [Phase 3: TBD](#phase-3-tbd)
- [Unresolved](#unresolved)
- [Summary of the Proposed Changes](#summary-of-the-proposed-changes)
- [Support for stateless pods](#support-for-stateless-pods)
- [Handling of stateless volumes](#handling-of-stateless-volumes)
- [Example of how idmap mounts work](#example-of-how-idmap-mounts-work)
- [Example without idmap mounts](#example-without-idmap-mounts)
- [Example without idmap mounts](#example-without-idmap-mounts-1)
- [Regarding the previous implementation for volumes](#regarding-the-previous-implementation-for-volumes)
- [Unresolved](#unresolved)
- [Test Plan](#test-plan)
- [Prerequisite testing updates](#prerequisite-testing-updates)
- [Unit tests](#unit-tests)
Expand All @@ -47,6 +47,8 @@
- [Implementation History](#implementation-history)
- [Drawbacks](#drawbacks)
- [Alternatives](#alternatives)
- [64k mappings?](#64k-mappings)
- [Allow runtimes to pick the mapping?](#allow-runtimes-to-pick-the-mapping)
- [Infrastructure Needed (Optional)](#infrastructure-needed-optional)
<!-- /toc -->

Expand Down Expand Up @@ -418,9 +420,9 @@ In other words, we can make sure the pod can read files instead of chowning them
all using the host IDs the pod is mapped to, by just using an idmap mount that
has the same mapping that we use for the pod user namespace.

##### Regarding the previous implementation for volumes
We previously added to the [KubeletVolumeHost
interface][kubeletVolumeHost-interface] the following method:
#### Regarding the previous implementation for volumes
We previously added to the [KubeletVolumeHost interface][kubeletVolumeHost-interface]
the following method:

```
GetHostIDsForPod(pod *v1.Pod, containerUID, containerGID *int64) (hostUID, hostGID *int64, err error)
Expand All @@ -431,7 +433,7 @@ components that implement the interface.

[kubeletVolumeHost-interface]: https://github.com/kubernetes/kubernetes/blob/36450ee422d57d53a3edaf960f86b356578fe996/pkg/volume/plugins.go#L322

#### Unresolved
### Unresolved

Here is a list of considerations raised in PRs discussion that hasn't yet
settle. This list is not exhaustive, we are just trying to put the things that
Expand Down

0 comments on commit dd330b3

Please sign in to comment.