Skip to content

Commit

Permalink
Address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
xing-yang committed Jun 5, 2023
1 parent 16e81ea commit 7547265
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
11 changes: 6 additions & 5 deletions keps/sig-storage/2268-non-graceful-shutdown/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -408,11 +408,12 @@ Pick one more of these and delete the rest.
-->
- [X] Metrics
- Metric name:
- We added new metrics `deleting_pods_total`, `deleting_pods_error_total`
in Pod GC Controller.
For Attach Detach Controller, there's already a metric:
`attachdetach_controller_forced_detaches`
There is also a `kube_node_spec_taint` in [kube-state-metrics](https://github.com/kubernetes/kube-state-metrics/blob/main/docs/node-metrics.md) that is a metric for the taint of a Kubernetes cluster node.
- New metrics are added in Pod GC Controller:
- `force_delete_pods_total`, the number of pods that are being forcefully deleted since the Pod GC Controller started.
- `force_delete_pod_errors_total`, the number of errors encountered when forcefully deleting the pods since the Pod GC Controller started.
- For Attach Detach Controller, there's already a metric:
- `attachdetach_controller_forced_detaches`, the number of times the Attach Detach Controller performed a forced detach.
- There is also a `kube_node_spec_taint` in [kube-state-metrics](https://github.com/kubernetes/kube-state-metrics/blob/main/docs/node-metrics.md) that is a metric for the taint of a Kubernetes cluster node.
- [Optional] Aggregation method:
- Components exposing the metric:
- [X] Other (treat as last resort)
Expand Down
4 changes: 2 additions & 2 deletions keps/sig-storage/2268-non-graceful-shutdown/kep.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,5 @@ disable-supported: true

# The following PRR answers are required at beta release
metrics:
- deleting_pods_total
- deleting_pods_error_total
- force_delete_pods_total
- force_delete_pod_errors_total

0 comments on commit 7547265

Please sign in to comment.