-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump go version #659
Conversation
Signed-off-by: Marek Chodor <[email protected]>
Hi @marqc. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hey, shouldn't we also update the version in https://github.com/kubernetes/dns/blob/master/Makefile#L43? |
I believe this is the exact line I changed. |
Sorry, my bad. It was just that go.mod has a major version pinned, while the image has patch version pinned. I was referring to this comment. |
Okay nevermind, 1.22 is 1.22.0 not the latest in this case I think. |
Can we get this merged? |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kl52752, marqc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.