-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comments to iptables rules generated by node-cache app #570
Conversation
Comments are saved as vars and reused for similar rules. It's less important that each rule is a thorough explanation of what's going on, and more important that network administrators know where the rule came from (i.e., this app) and why it's being added.
Welcome @2rs2ts! |
Hi @2rs2ts. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2rs2ts, dpasiukevich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Comments are saved as vars and reused for similar rules. It's less important that each rule is a thorough explanation of what's going on, and more important that network administrators know where the rule came from (i.e., this app) and why it's being added.
Of course, I'm completely open to feedback on what the actual comments should say, whether there should be more unique comments rather than just the 2 I started with, how I should format the code, how to make it localizable, etc.
I tested this in my own Kubernetes cluster by confirming the result with
iptables-save
after rolling it out.Fixes #566