Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the divisor field in resourceFieldRefs should be a string #9548

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

elohmeier
Copy link
Contributor

This fixes the type in the yaml, introduced in #9486.

See also:

"""
ResourceFieldSelector represents container resources (cpu, memory) and their output format
"""
type v1_ResourceFieldSelector {
"""Container name: required for volumes, optional for env vars"""
containerName: String
divisor: String
"""Required: resource to select"""
resource: String!
}

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 18, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 18, 2024
Copy link
Member

@floreks floreks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elohmeier, floreks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2024
@floreks floreks added the kind/bug Categorizes issue or PR as related to a bug. label Oct 22, 2024
@floreks floreks merged commit 029a119 into kubernetes:master Oct 22, 2024
15 of 22 checks passed
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.85%. Comparing base (1b58a29) to head (e85a2eb).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9548      +/-   ##
==========================================
- Coverage   36.86%   36.85%   -0.01%     
==========================================
  Files         283      283              
  Lines       14100    14100              
  Branches      183      183              
==========================================
- Hits         5198     5197       -1     
- Misses       8680     8681       +1     
  Partials      222      222              

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants