Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): add optional in-memory cache to client #9521

Merged
merged 63 commits into from
Oct 22, 2024
Merged

Conversation

floreks
Copy link
Member

@floreks floreks commented Oct 14, 2024

  • Added dynamic cache support
  • Dashboard is now using a single logger (klog). Logging level can be easily controlled via --v=<LEVEL> flag.
  • Default log level is set to 1 and requests/responses are no longer being logged by default
  • Added optional profiler flag --profiler that allows enabling go profiler
  • Added optional prometheus flag --prometheus-enabled that will expose /metrics endpoint. Adding custom metrics is planned later on.
  • Added dev images push from PRs to DockerHub.
  • Fixed helm lint CI action
  • Updated helm notes to use configured namespace instead of hardcoded one

TODO

  • Add cache feature documentation and architecture overview
  • Add cache args to documentation
  • Review and update other args

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 14, 2024
@floreks floreks changed the title feat(client): add optional in-memory cache to client wip: feat(client): add optional in-memory cache to client Oct 14, 2024
@floreks floreks marked this pull request as draft October 14, 2024 15:42
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 14, 2024
@floreks floreks self-assigned this Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 5.87156% with 513 lines in your changes missing coverage. Please review.

Project coverage is 35.94%. Comparing base (31d5f5d) to head (616826a).
Report is 44 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9521      +/-   ##
==========================================
- Coverage   37.08%   35.94%   -1.15%     
==========================================
  Files         283      301      +18     
  Lines       11830    14479    +2649     
  Branches      202      183      -19     
==========================================
+ Hits         4387     5204     +817     
- Misses       7168     9051    +1883     
+ Partials      275      224      -51     

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 15, 2024
@floreks floreks added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 15, 2024
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 16, 2024
@floreks floreks marked this pull request as ready for review October 22, 2024 13:06
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2024
@maciaszczykm
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9d28815 into master Oct 22, 2024
19 checks passed
@maciaszczykm maciaszczykm deleted the api/cache branch October 22, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants