-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor verber and fix client-side throttling due to client init misconfiguration #8900
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8900 +/- ##
==========================================
- Coverage 37.62% 37.20% -0.42%
==========================================
Files 256 255 -1
Lines 11187 11149 -38
Branches 158 158
==========================================
- Hits 4209 4148 -61
- Misses 6727 6790 +63
+ Partials 251 211 -40 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks, maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [kubernetes-dashboard](https://github.com/kubernetes/dashboard) | patch | `7.3.0` -> `7.3.1` | --- ### Release Notes <details> <summary>kubernetes/dashboard (kubernetes-dashboard)</summary> ### [`v7.3.1`](https://github.com/kubernetes/dashboard/releases/tag/kubernetes-dashboard-7.3.1) [Compare Source](https://github.com/kubernetes/dashboard/compare/kubernetes-dashboard-7.3.0...kubernetes-dashboard-7.3.1) #### What's Changed - chore(chart): bump chart to 7.3.1 by [@​floreks](https://github.com/floreks) in [https://github.com/kubernetes/dashboard/pull/8902](https://github.com/kubernetes/dashboard/pull/8902) - feat: refactor verber and fix client-side throttling due to client init misconfiguration by [@​floreks](https://github.com/floreks) in [https://github.com/kubernetes/dashboard/pull/8900](https://github.com/kubernetes/dashboard/pull/8900) **Full Changelog**: kubernetes/dashboard@kubernetes-dashboard-7.3.0...kubernetes-dashboard-7.3.1 #### Installation ```sh helm repo add kubernetes-dashboard https://kubernetes.github.io/dashboard/ helm upgrade --install kubernetes-dashboard kubernetes-dashboard/kubernetes-dashboard --create-namespace --namespace kubernetes-dashboard ``` #### Compatibility | Kubernetes version | 1.27 | 1.28 | 1.29 | |--------------------|-----|-----|-----| | Compatibility | ? | ? | ✓ | - `✓` Fully supported version range. - `?` Due to breaking changes between Kubernetes API versions, some features might not work correctly in the Dashboard. #### Images docker.io/kubernetesui/dashboard-api:1.4.3 docker.io/kubernetesui/dashboard-auth:1.1.3 docker.io/kubernetesui/dashboard-metrics-scraper:1.1.1 docker.io/kubernetesui/dashboard-web:1.3.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yODIuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI4Mi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9wYXRjaCJdfQ==--> Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
API
make helm
andmake helm-release
Common (Client)
baseConfig
used to create a client. It wasn't correctly defaulting QPS/Burst causing metrics gathering to throttle significantly. Fixes ui updates seem to be too slow #8835Web