Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OWNERS_ALIASES #7620

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Conversation

shu-mutou
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 12, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 12, 2023
@codecov
Copy link

codecov bot commented Feb 12, 2023

Codecov Report

Merging #7620 (02b4977) into master (5925604) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7620      +/-   ##
==========================================
+ Coverage   42.08%   42.11%   +0.03%     
==========================================
  Files         217      217              
  Lines       12084    12081       -3     
  Branches      179      179              
==========================================
+ Hits         5085     5088       +3     
+ Misses       6715     6708       -7     
- Partials      284      285       +1     

@shu-mutou
Copy link
Contributor Author

@maciaszczykm @floreks Should we add historical emeritus maintainers?

@maciaszczykm
Copy link
Member

@shu-mutou As you want. I think it's also somewhere in other Kubernetes repo.

@shu-mutou
Copy link
Contributor Author

I want to respect also past maintainers, so I'll check the past OWNERS file and add them.

To respect historical maintainers, added them to emeritus.
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 14, 2023
@shu-mutou
Copy link
Contributor Author

@maciaszczykm Done. PTAL. Thanks!!

@maciaszczykm
Copy link
Member

Great.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm, shu-mutou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [maciaszczykm,shu-mutou]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c583f9e into kubernetes:master Feb 14, 2023
@shu-mutou shu-mutou deleted the update-owners branch February 14, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants