Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update web dependencies #7619

Merged
merged 6 commits into from
Feb 14, 2023
Merged

Update web dependencies #7619

merged 6 commits into from
Feb 14, 2023

Conversation

maciaszczykm
Copy link
Member

@maciaszczykm maciaszczykm commented Feb 10, 2023

Updates Angular and other web dependencies to latest versions. Angular Material was not updated yet as it visually breaks the app. We will have to do it from a separate change. See: https://medium.com/ngconf/whats-new-in-angular-material-15-a196e606a33.

Closes #7601.
Closes #7599.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 10, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Feb 10, 2023
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #7619 (0c0215f) into master (2917ff4) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7619      +/-   ##
==========================================
+ Coverage   42.11%   42.16%   +0.05%     
==========================================
  Files         217      217              
  Lines       12081    12092      +11     
  Branches      179      179              
==========================================
+ Hits         5088     5099      +11     
  Misses       6708     6708              
  Partials      285      285              

@maciaszczykm maciaszczykm removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Feb 10, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Feb 14, 2023
@k8s-ci-robot
Copy link
Contributor

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

  • 7f2a5e5 Run ng update @angular/core@15 @angular/cli@15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@maciaszczykm maciaszczykm removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Feb 14, 2023
@maciaszczykm
Copy link
Member Author

Updated Node version and fixed unit tests. PTAL.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maciaszczykm maciaszczykm added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2023
@maciaszczykm maciaszczykm merged commit 578974d into master Feb 14, 2023
@maciaszczykm maciaszczykm deleted the maciaszczykm/deps branch March 17, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix depricated package Upgrade Angular 14 to Angular 15
4 participants