Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support kind in development container #7602

Merged
merged 10 commits into from
Feb 14, 2023
Merged

Support kind in development container #7602

merged 10 commits into from
Feb 14, 2023

Conversation

shu-mutou
Copy link
Contributor

@shu-mutou shu-mutou commented Jan 24, 2023 •
edited
Loading

As a default, run dashboard with kind cluster in development container.
hack/develop/run-dev-container.sh

Ref: #7582

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 24, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2023
@codecov
Copy link

codecov bot commented Jan 24, 2023 •
edited
Loading

Codecov Report

Merging #7602 (aad22e7) into master (2917ff4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7602   +/-   ##
=======================================
  Coverage   42.11%   42.11%           
=======================================
  Files         217      217           
  Lines       12081    12081           
  Branches      179      179           
=======================================
  Hits         5088     5088           
  Misses       6708     6708           
  Partials      285      285

@shu-mutou
Copy link
Contributor Author

Self check and clean up are needed.

@shu-mutou
Copy link
Contributor Author

Also, documentation should be updated.

@shu-mutou
Copy link
Contributor Author

Dashboard is woriking with kind in development container now!
However, browser can not access with https://localhost:4442, but can access with http://172.xx.0.x:4443.
More investigation needed....

@shu-mutou shu-mutou requested review from maciaszczykm and removed request for jeefy January 26, 2023 08:53
@shu-mutou
Copy link
Contributor Author

/retitle Support kind in development container

@k8s-ci-robot k8s-ci-robot changed the title [WIP] Support kind in development container Support kind in development container Jan 26, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2023
@shu-mutou
Support kind in development container
c165831 
As a default, run dashboard with `kind` cluster in development container.
@shu-mutou
Use kind docker network
4cf0197 
Also, fix some problems.
@shu-mutou
Use docker network kubernetes-dashboard in kind cluster
a212106
@shu-mutou
Added cluster role for development
3e1ea31
@shu-mutou
Support kind in development container
ab58a9e 
As a default, run dashboard with `kind` cluster in development container.
@shu-mutou
Use kind docker network
917546a 
Also, fix some problems.
@shu-mutou
Add license header to yaml files
317ae51
@shu-mutou
Bump docker to 23.0.1
aad22e7 
docker 23.0.0 does not works.
@shu-mutou
Copy link
Contributor Author

docker 23.0.0 has bug. Development container does not work with it. Please update docker 23.0.1 or later.

@shu-mutou
Copy link
Contributor Author

the bug in 23.0.0 fixed by moby/moby#44928
COPY in Dockerfile was failed by the bug.

@maciaszczykm
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm, shu-mutou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [maciaszczykm,shu-mutou]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8f844cd into kubernetes:master Feb 14, 2023
@shu-mutou shu-mutou deleted the dev-container branch February 14, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciaszczykm maciaszczykm maciaszczykm approved these changes

@floreks floreks Awaiting requested review from floreks

Assignees

@maciaszczykm maciaszczykm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shu-mutou @maciaszczykm @k8s-ci-robot