-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump k8s modules to 0.26.1 #7568
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7568 +/- ##
==========================================
+ Coverage 42.08% 42.11% +0.03%
==========================================
Files 217 217
Lines 12084 12081 -3
Branches 179 179
==========================================
+ Hits 5085 5088 +3
+ Misses 6715 6708 -7
- Partials 284 285 +1 |
36fccd1
to
38ab387
Compare
@shu-mutou did you check it with K8s 1.26? It would be good to wait for kind release to run e2e tests against 1.26 cluster in CI as well. |
/hold |
Actually, I did not check this with k8s 1.26.0. I'm using latest minikube (v1.28.0) that also have not support 1.26.0 yet. Let's wait for a while. |
By the way, this works fine on the latest v1.28.0 minikube (k8s 1.25.3). |
@shu-mutou Could you also check for deprecated APIs like one in #7604? |
Use kindest/node:v1.26.0 image.
I found new release for minikube that supports k8s v1.26.1, and how to set k8s version for kind and helm/kind-action. So I restart this and checking deprecated APIs. 🚀 |
Deprecated APIs are checking at Issue #7606 |
@maciaszczykm PTAL. |
I checked this with k8s v1.26.1 (constructed by minikube v0.29.0), this seems to work.... |
My minikube (k8s v1.26.1) was started up properly! And I confirmed this PR works fine!! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maciaszczykm, shu-mutou The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Also, bump k8s cluster version to v1.26.0 that
kind
constructs in CI, and fix deprecated APIs.Fixes: #7604
Fixes: #7606