Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k8s modules to 0.26.1 #7568

Merged
merged 12 commits into from
Feb 1, 2023
Merged

Bump k8s modules to 0.26.1 #7568

merged 12 commits into from
Feb 1, 2023

Conversation

shu-mutou
Copy link
Contributor

@shu-mutou shu-mutou commented Dec 29, 2022

Also, bump k8s cluster version to v1.26.0 that kind constructs in CI, and fix deprecated APIs.

Fixes: #7604
Fixes: #7606

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 29, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 29, 2022
@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Merging #7568 (9b4afb2) into master (5925604) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #7568      +/-   ##
==========================================
+ Coverage   42.08%   42.11%   +0.03%     
==========================================
  Files         217      217              
  Lines       12084    12081       -3     
  Branches      179      179              
==========================================
+ Hits         5085     5088       +3     
+ Misses       6715     6708       -7     
- Partials      284      285       +1     

@shu-mutou shu-mutou force-pushed the k8s-26 branch 13 times, most recently from 36fccd1 to 38ab387 Compare December 29, 2022 07:18
@maciaszczykm
Copy link
Member

@shu-mutou did you check it with K8s 1.26?

It would be good to wait for kind release to run e2e tests against 1.26 cluster in CI as well.

@shu-mutou
Copy link
Contributor Author

/hold
until new version of kind that supports k8s 1.26.0.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 3, 2023
@shu-mutou
Copy link
Contributor Author

Actually, I did not check this with k8s 1.26.0. I'm using latest minikube (v1.28.0) that also have not support 1.26.0 yet. Let's wait for a while.

@shu-mutou
Copy link
Contributor Author

By the way, this works fine on the latest v1.28.0 minikube (k8s 1.25.3).

@shu-mutou
Copy link
Contributor Author

kind and minikube do not support k8s 1.26 yet.

@maciaszczykm
Copy link
Member

@shu-mutou Could you also check for deprecated APIs like one in #7604?

@shu-mutou
Copy link
Contributor Author

I found new release for minikube that supports k8s v1.26.1, and how to set k8s version for kind and helm/kind-action. So I restart this and checking deprecated APIs. 🚀

@shu-mutou
Copy link
Contributor Author

Deprecated APIs are checking at Issue #7606

@shu-mutou
Copy link
Contributor Author

@maciaszczykm PTAL.
I filled the check list for deprecated APIs (#7606).
Also, I created two issues (#7607, #7608) that should be fixed in the later PRs.
Thanks!!

@shu-mutou
Copy link
Contributor Author

I checked this with k8s v1.26.1 (constructed by minikube v0.29.0), this seems to work....
My minikube started showing node status error, so I may need to investigate a bit more.....

@shu-mutou
Copy link
Contributor Author

My minikube (k8s v1.26.1) was started up properly! And I confirmed this PR works fine!!

@maciaszczykm maciaszczykm merged commit 50d38f4 into kubernetes:master Feb 1, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm, shu-mutou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [maciaszczykm,shu-mutou]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shu-mutou shu-mutou deleted the k8s-26 branch February 3, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check deprecated APIs for v1.26 Cronjob view breaks on GKE v1.25 with latest 2.7.0
3 participants