Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup development container for new architecture #7563

Merged
merged 6 commits into from
Dec 31, 2022

Conversation

shu-mutou
Copy link
Contributor

Fix development container, to support new architecture.

For now, this supports followings:

  • Access to outside Kubernetes cluster using kubeconfig file
  • Build and run dashboard with make run

The other make commands will support in the future.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 18, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2022
@codecov
Copy link

codecov bot commented Dec 18, 2022

Codecov Report

Merging #7563 (e09e005) into master (e175cf1) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7563      +/-   ##
==========================================
- Coverage   42.10%   42.09%   -0.01%     
==========================================
  Files         217      217              
  Lines       12084    12084              
  Branches      179      179              
==========================================
- Hits         5088     5087       -1     
- Misses       6711     6712       +1     
  Partials      285      285              

@shu-mutou
Copy link
Contributor Author

@maciaszczykm
@floreks
My development environment relies on this, so I would appreciate it if you could check it out ASAP. Thanks!!

@k8s-ci-robot k8s-ci-robot added language/ja Updates or issues for Japanese translations. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 31, 2022
@floreks
Copy link
Member

floreks commented Dec 31, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 31, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, shu-mutou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 42fc880 into kubernetes:master Dec 31, 2022
@shu-mutou
Copy link
Contributor Author

@floreks Thanks! And happy new year!!

@shu-mutou shu-mutou deleted the dev-container branch January 1, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Updates or issues for Japanese translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants