Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix graphs when using translations #7546

Merged
merged 1 commit into from
Nov 25, 2022
Merged

Fix graphs when using translations #7546

merged 1 commit into from
Nov 25, 2022

Conversation

maciaszczykm
Copy link
Member

Closes #7515.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 25, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 25, 2022
@codecov
Copy link

codecov bot commented Nov 25, 2022 •
edited
Loading

Codecov Report

Merging #7546 (6921db5) into master (1f109d7) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #7546      +/-   ##
==========================================
- Coverage   42.10%   42.07%   -0.04%     
==========================================
  Files         217      217              
  Lines       12084    12084              
  Branches      179      179              
==========================================
- Hits         5088     5084       -4     
- Misses       6711     6716       +5     
+ Partials      285      284       -1

floreks
floreks approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@floreks floreks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b06fc17 into master Nov 25, 2022
@floreks floreks mentioned this pull request Jan 27, 2023
Closed
@maciaszczykm maciaszczykm deleted the maciaszczykm/fix-graphs branch March 17, 2023 11:06
@maciaszczykm maciaszczykm mentioned this pull request Mar 24, 2023
Closed
@maciaszczykm maciaszczykm mentioned this pull request Sep 26, 2023
Closed
jc01rho pushed a commit to jc01rho/dashboard that referenced this pull request Jul 9, 2024
@maciaszczykm @jc01rho
Fix graphs when using translations (kubernetes#7546)
340f0df
jc01rho pushed a commit to jc01rho/dashboard that referenced this pull request Jul 9, 2024
@maciaszczykm @jc01rho
Fix graphs when using translations (kubernetes#7546)
136b8cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floreks floreks floreks approved these changes

@shu-mutou shu-mutou Awaiting requested review from shu-mutou

Assignees

@floreks floreks

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workload status circle draws black
3 participants
@maciaszczykm @k8s-ci-robot @floreks