Helm Chart: if no image.tag is set, use default appVersion of Chart.yaml #7531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
desaintmartin
changed the title
k8s-ci-robot
added
the
size/S
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: desaintmartin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Codecov Report
@@ Coverage Diff @@
## master #7531 +/- ##
=======================================
Coverage 42.09% 42.10%
=======================================
Files 217 217
Lines 12084 12084
Branches 179 179
=======================================
+ Hits 5087 5088 +1
+ Misses 6712 6711 -1
Partials 285 285 |
|
@desaintmartin Can you rebase? |
k8s-ci-robot
added
the
needs-rebase
…aml. One less file to edit when updating dashboard.
desaintmartin
force-pushed
the
version
branch
from
b8842a2
to
be3db82
Compare
k8s-ci-robot
removed
the
needs-rebase
k8s-ci-robot
added
size/XS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helm Chart: if no image.tag is set, use default appVersion of Chart.yaml.
One less file to edit when updating dashboard.