Replace deprecated k8s registry references. #7513
Conversation
Problem: Previously all of Kubernetes' image hosting has been out of gcr.io. There were significant egress costs associated with this when images were pulled from entities outside gcp. Refer to https://github.com/kubernetes/k8s.io/wiki/New-Registry-url-for-Kubernetes-(registry.k8s.io) Solution: As highlighted at KubeCon NA 2022 k8s infra SIG update, the replacement for k8s.gcr.io which is registry.k8s.io is now ready for mainstream use and the old k8s.gcr.io has been formally deprecated and projects are requested to migrate off it. This commit migrates all remaining references for kubernetes/dashboard to registry.k8s.io. Signed-off-by: James Blair <[email protected]>
|
|
k8s-ci-robot
added
the
cncf-cla: no
|
Welcome @jmhbnz! |
k8s-ci-robot
added
the
size/XS
k8s-ci-robot
added
cncf-cla: yes
| @@ -161,7 +161,7 @@ func TestEvalEnvFrom(t *testing.T) { | |||
| { | |||
| container: v1.Container{ | |||
| Name: "echoserver", | |||
| Image: "k8s.gcr.io/echoserver", | |||
| Image: "registry.k8s.io/echoserver", | |||
There was a problem hiding this comment.
It doesn't have latest version available, but it's only for testing so we can keep it like it is.
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmhbnz, maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Codecov Report
@@ Coverage Diff @@
## master #7513 +/- ##
==========================================
+ Coverage 42.07% 42.10% +0.03%
==========================================
Files 217 217
Lines 12084 12084
Branches 179 179
==========================================
+ Hits 5084 5088 +4
+ Misses 6716 6711 -5
- Partials 284 285 +1 |
Problem:
Previously all of Kubernetes' image hosting has been out of gcr.io. There were significant egress costs associated with this when images were pulled from entities outside gcp. Refer to https://github.com/kubernetes/k8s.io/wiki/New-Registry-url-for-Kubernetes-(registry.k8s.io)
Solution:
As highlighted at KubeCon NA 2022 k8s infra SIG update, the replacement for k8s.gcr.io which is registry.k8s.io is now ready for mainstream use and the old k8s.gcr.io has been formally deprecated and projects are requested to migrate off it. This commit migrates all remaining references for kubernetes/dashboard to registry.k8s.io.