Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update Spanish localization #7492

Merged
merged 2 commits into from
Nov 14, 2022
Merged

feat: update Spanish localization #7492

merged 2 commits into from
Nov 14, 2022

Conversation

anyulled
Copy link
Contributor

@anyulled anyulled commented Oct 3, 2022 •
edited
Loading

Update of the Spanish translation of the Dashboard UI

Followed instructions on Internationalization

Relates to #7316

anyulled and others added 2 commits October 3, 2022 00:13
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 3, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 3, 2022
@anyulled anyulled changed the title WIP: Spanish localistation WIP: feat: update Spanish localization Oct 3, 2022
@anyulled anyulled changed the title WIP: feat: update Spanish localization feat: update Spanish localization Oct 10, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2022
@anyulled
Copy link
Contributor Author

Hi @jeefy, would you mind checking this pull request?

@shu-mutou shu-mutou requested review from maciaszczykm and floreks and removed request for jeefy November 3, 2022 10:46
@maciaszczykm
Copy link
Member

/retest
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anyulled, maciaszczykm, raelga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maciaszczykm
Copy link
Member

Merging as tests have failed only because of Codecov.

@maciaszczykm maciaszczykm merged commit fe640c9 into kubernetes:master Nov 14, 2022
@anyulled
Copy link
Contributor Author

Merging as tests have failed only because of Codecov.

thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raelga raelga raelga approved these changes

@maciaszczykm maciaszczykm Awaiting requested review from maciaszczykm

@floreks floreks Awaiting requested review from floreks

Assignees

@maciaszczykm maciaszczykm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anyulled @maciaszczykm @k8s-ci-robot @raelga