Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check the existence of the http member of a ingress rule before iterating through it #7481

Merged
merged 1 commit into from
Sep 23, 2022
Merged

check the existence of the http member of a ingress rule before iterating through it #7481

merged 1 commit into from
Sep 23, 2022

Conversation

shankerwangmiao
Copy link
Contributor

@shankerwangmiao shankerwangmiao commented Sep 23, 2022 •
edited
Loading

Fixes: #7480

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Sep 23, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 23, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: shankerwangmiao / name: Miao Wang (adb1fd3)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 23, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @shankerwangmiao!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 23, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 23, 2022
@shankerwangmiao
check the existence of the http member of a ingress rule before itera…
72b7e0a 
…ting through it

Fixes: issue <#7480>

Signed-off-by: Miao Wang <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Sep 23, 2022
@floreks
Copy link
Member

floreks commented Sep 23, 2022

Thanks for the fix
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, shankerwangmiao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, shankerwangmiao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2022
@codecov
Copy link

codecov bot commented Sep 23, 2022 •
edited
Loading

Codecov Report

Merging #7481 (72b7e0a) into master (cf08a27) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7481      +/-   ##
==========================================
- Coverage   42.23%   42.22%   -0.01%     
==========================================
  Files         220      220              
  Lines       12110    12110              
  Branches      179      179              
==========================================
- Hits         5115     5114       -1     
- Misses       6710     6711       +1     
  Partials      285      285

@k8s-ci-robot k8s-ci-robot merged commit dfebd22 into kubernetes:master Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floreks floreks floreks approved these changes

@shu-mutou shu-mutou Awaiting requested review from shu-mutou

Assignees

@floreks floreks

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get http panic runtime error: invalid memory address or nil pointer dereference when viewing a service
3 participants
@shankerwangmiao @k8s-ci-robot @floreks