fix: update Secret with non-latin1 UTF-8 string #7477
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is a new PR against the current refactored master)
This PR will fix #7411.
Currently, I implement the fix using a third-party library: js-base64, and its size seems okay (minified ~8kb without tree-shaking; total build size: original 251388kb -> after 251392kb, +4kb).
Another way is using the
unescape
andencodeURIComponent
trick:However, considered
unescape
is deprecated, maybe we should avoid using it. Am I right?