Use batch/v1 for fetching cronjob jobs

[neoaggelos]

Summary

Follow up for #7301

#7301 has fixed the cronjobs list page, but still produces an issue when opening the details of a cronjob. This is because GetCronJobJobs() still uses batch/v1beta1 (which seems like it was missed in the original PR). The proposed change fixes the issue for me, and the page then opens properly.

A quick grep for BatchV1beta1() does not point to usage of this client in other places, so this fix should be sufficient.

[k8s-ci-robot]

Welcome @neoaggelos!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[maciaszczykm]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maciaszczykm, neoaggelos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Merging #7465 (5dab41b) into master (92a8491) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #7465      +/-   ##
==========================================
- Coverage   42.29%   42.27%   -0.03%     
==========================================
  Files         220      220              
  Lines       12123    12123              
  Branches      179      179              
==========================================
- Hits         5128     5125       -3     
- Misses       6710     6714       +4     
+ Partials      285      284       -1     

[Joseph-Goergen]

Can we get this backported to 2.7?

[Joseph-Goergen]

Any chance that we can get another 2.7 release soon so that we can pull in this fix? We have a few customers that have been running into this problem

[maciaszczykm]

@Joseph-Goergen Sorry, we do not have enough people working on the project at the moment to be able to do backport. Our main priority is #7544 which would allow us to create new release.

[bhutkovskyysos]

Hi @maciaszczykm ,
What would it take to rebuild kubernetes dashboard docker image from the master branch to consume latest changes? That way folks could start using it sooner before the official release is made. Thanks!

[zigmund]

Few months later still the issue.

[Gakhramanzode]

@neoaggelos @maciaszczykm @Joseph-Goergen @bhutkovskyysos can you tell me , is the problem still relevant or has everything been fixed ?

[neoaggelos]

Hi @Gakhramanzode, looks to be resolved in https://github.com/kubernetes/dashboard/releases/tag/v3.0.0-alpha0, but there has not been any 2.7.x release that includes the fix.

[Gakhramanzode]

Hi @Gakhramanzode, looks to be resolved in https://github.com/kubernetes/dashboard/releases/tag/v3.0.0-alpha0, but there has not been any 2.7.x release that includes the fix.

Do we have to wait for the release? If so, when do we expect it to happen ?

[mimmus]

2.7.0, as latest stable release, is included in many bundles and commercial products.
And 3.0.0 is a big chance, probably we will not see soon.
Any chance that we can get another 2.7 release soon so that we can pull in this fix? We have a few customers that have been running into this problem...

[Gakhramanzode]

@mimmus It's sad to hear that. but I wish you success and good luck