-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Korean localization for dashboard(5501-6000) #7446
Korean localization for dashboard(5501-6000) #7446
Conversation
Welcome @yuzin9712! |
Codecov Report
@@ Coverage Diff @@
## master #7446 +/- ##
=======================================
Coverage 44.22% 44.22%
=======================================
Files 46 46
Lines 1282 1282
Branches 178 178
=======================================
Hits 567 567
Misses 677 677
Partials 38 38 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yuzin9712
Thank you for your contribution!
I have a minor comment :)
Please check it.
i18n/ko/messages.ko.xlf
Outdated
<context-group purpose="location"> | ||
<context context-type="sourcefile">src/app/frontend/resource/workloads/cronjob/detail/template.html</context> | ||
<context context-type="linenumber">76</context> | ||
</context-group> | ||
</trans-unit> | ||
<trans-unit id="4343527844687153745" datatype="html"> | ||
<source>Starting deadline seconds</source> | ||
<target state="new">Starting deadline seconds</target> | ||
<target>시작 기한 시간</target> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<target>시작 기한 시간</target> | |
<target>시작을 위한 기한(starting deadline seconds)</target> |
GUI에서 어떻게 나올지 확인은 못해봤지만,
해당 항목은 크론잡의 field 항목인 것 같습니다.
그래서 일단 원문을 추가적으로 알려주는 것이 좋을 것 같습니다.
https://kubernetes.io/ko/docs/concepts/workloads/controllers/cron-jobs/#cron-job-limitations
/assign |
Signed-off-by: yuzin9712 <[email protected]>
fb4ada6
to
af38769
Compare
Thanks! @yuzin9712 /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: seokho-son, yuzin9712 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: yuzin9712 [email protected]
Related Issue: #7424
Updated line number: 5501 - 6000
Change
<target state="new">
to<target>
and translate into Korean.