Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Korean localization for dashboard(5501-6000) #7446

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

yuzin9712
Copy link
Contributor

Signed-off-by: yuzin9712 [email protected]

Related Issue: #7424

Updated line number: 5501 - 6000

Change <target state="new"> to <target> and translate into Korean.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 12, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @yuzin9712!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 12, 2022
@k8s-ci-robot k8s-ci-robot added the language/ko Updates or issues for Korean translations. label Sep 12, 2022
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #7446 (af38769) into master (f547f75) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7446   +/-   ##
=======================================
  Coverage   44.22%   44.22%           
=======================================
  Files          46       46           
  Lines        1282     1282           
  Branches      178      178           
=======================================
  Hits          567      567           
  Misses        677      677           
  Partials       38       38           

Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yuzin9712
Thank you for your contribution!
I have a minor comment :)
Please check it.

<context-group purpose="location">
<context context-type="sourcefile">src/app/frontend/resource/workloads/cronjob/detail/template.html</context>
<context context-type="linenumber">76</context>
</context-group>
</trans-unit>
<trans-unit id="4343527844687153745" datatype="html">
<source>Starting deadline seconds</source>
<target state="new">Starting deadline seconds</target>
<target>시작 기한 시간</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<target>시작 기한 시간</target>
<target>시작을 위한 기한(starting deadline seconds)</target>

GUI에서 어떻게 나올지 확인은 못해봤지만,
해당 항목은 크론잡의 field 항목인 것 같습니다.
그래서 일단 원문을 추가적으로 알려주는 것이 좋을 것 같습니다.

https://kubernetes.io/ko/docs/concepts/workloads/controllers/cron-jobs/#cron-job-limitations

@seokho-son
Copy link
Member

/assign

@seokho-son
Copy link
Member

Thanks! @yuzin9712

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son, yuzin9712

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2022
@k8s-ci-robot k8s-ci-robot merged commit fb2b629 into kubernetes:master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Updates or issues for Korean translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants