Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Korean localization dashboard(2001-2500) #7437

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Update Korean localization dashboard(2001-2500) #7437

merged 1 commit into from
Sep 13, 2022

Conversation

gy-ulbak96
Copy link
Contributor

@gy-ulbak96 gy-ulbak96 commented Sep 10, 2022 •
edited
Loading

Signed-off-by: gy-ulbak96 [email protected]

Issues: #7424

Updated line number : 2001-2500

  • Changed <target state="new"> to <target>

  • Translate strings between <target state="new">Strings to translate</target>.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Updates or issues for Korean translations. labels Sep 10, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @gy-ulbak96!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 10, 2022
@gy-ulbak96 gy-ulbak96 changed the title Update Korean localization dashboard(2000-2500) Update Korean localization dashboard(2001-2500) Sep 10, 2022
seokho-son
seokho-son reviewed Sep 11, 2022
View reviewed changes
Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gy-ulbak96 !

I have one mirnir comment. PTAL. :)

i18n/ko/messages.ko.xlf Outdated
@@ -2330,7 +2330,7 @@
</trans-unit>
<trans-unit id="6157826473930539567" datatype="html">
<source>Horizontal Pod Autoscalers</source>
<target state="new">Horizontal Pod Autoscalers</target>
<target>Horizontal Pod Autoscalers</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<target>Horizontal Pod Autoscalers</target>
<target>호레잔틀 파드 오토스케일러</target>

다른 영문이 모두 번역되어 있는 상황을 고려하려 수정해보았습니다. (k/website 와는 일부 다르게 한글화 될 수 있을 것 같습니다.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정하였습니다. 확인 감사합니다 :)

@seokho-son
Copy link
Member

Hi @shu-mutou could you enable workflows for this PR ? :)

@seokho-son
Copy link
Member

/assign

@codecov
Copy link

codecov bot commented Sep 13, 2022 •
edited
Loading

Codecov Report

Merging #7437 (aac123b) into master (e511a06) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7437   +/-   ##
=======================================
  Coverage   44.22%   44.22%           
=======================================
  Files          46       46           
  Lines        1282     1282           
  Branches      178      178           
=======================================
  Hits          567      567           
  Misses        677      677           
  Partials       38       38

@seokho-son
Copy link
Member

Thanks !

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gy-ulbak96, seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8125b2a into kubernetes:master Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seokho-son seokho-son seokho-son left review comments

@gochist gochist Awaiting requested review from gochist

Assignees

@seokho-son seokho-son

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Updates or issues for Korean translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gy-ulbak96 @k8s-ci-robot @seokho-son