-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Simplified Chinese translation #7416
Updated Simplified Chinese translation #7416
Conversation
/assign @tengqm @helight @tanjunchen |
Codecov Report
@@ Coverage Diff @@
## master #7416 +/- ##
=======================================
Coverage 44.22% 44.22%
=======================================
Files 46 46
Lines 1282 1282
Branches 178 178
=======================================
Hits 567 567
Misses 677 677
Partials 38 38 |
<context-group purpose="location"> | ||
<context context-type="sourcefile">src/app/frontend/resource/workloads/deployment/detail/template.html</context> | ||
<context context-type="linenumber">174</context> | ||
</context-group> | ||
</trans-unit> | ||
<trans-unit id="1257046302587502112" datatype="html"> | ||
<source>New Replica Set</source> | ||
<target state="new">New Replica Set</target> | ||
<target>新的 Replica Set</target> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<target>新的 Replica Set</target> | |
<target>新的 ReplicaSet</target> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不翻译的部分应与上面<source>
中的内容保持一致
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
英文的表达是有问题的,翻译的时候可以酌情修正。
a27916c
to
9086340
Compare
@tengqm 感谢你的审核,需要修改的部分我已经修改,其他需要讨论的部分我已回复。请再次审核。 |
<context-group purpose="location"> | ||
<context context-type="sourcefile">src/app/frontend/common/components/securitycontext/template.html</context> | ||
<context context-type="linenumber">54</context> | ||
</context-group> | ||
</trans-unit> | ||
<trans-unit id="3321884531921673789" datatype="html"> | ||
<source>Run as User</source> | ||
<target state="new">Run as User</target> | ||
<target>用户身份</target> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<target>用户身份</target> | |
<target>以用户身份运行</target> |
<context-group purpose="location"> | ||
<context context-type="sourcefile">src/app/frontend/common/components/securitycontext/template.html</context> | ||
<context context-type="linenumber">60</context> | ||
</context-group> | ||
</trans-unit> | ||
<trans-unit id="7769329651019167020" datatype="html"> | ||
<source>Run as Group</source> | ||
<target state="new">Run as Group</target> | ||
<target>组身份</target> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<target>组身份</target> | |
<target>以组身份运行</target> |
<context-group purpose="location"> | ||
<context context-type="sourcefile">src/app/frontend/common/components/securitycontext/template.html</context> | ||
<context context-type="linenumber">65</context> | ||
</context-group> | ||
</trans-unit> | ||
<trans-unit id="7517495778455112288" datatype="html"> | ||
<source>Run as Non-Root</source> | ||
<target state="new">Run as Non-Root</target> | ||
<target>非 Root 身份</target> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<target>非 Root 身份</target> | |
<target>以非 Root 身份运行</target> |
@shu-mutou |
9086340
to
a4c64e5
Compare
Sorry for late response.
I don't know. It seems that way from the beginning. But from a UX perspective, I think @maciaszczykm @floreks Do you know why? |
Yes, this is a human readable format for better UX and we want to keep it that way. |
@tengqm I suggest to refer to the opinion of the dashboard maintainer and not modify these words. |
With my SIG docs maintainer's hat on, I don't think we should spell StatefulSet as "stateful set", ConfigMap as "config map", or HorizontalPodAutoscaler as "horizontal pod autoscaler". This has been documented as documentation style here. This is to avoid confusion when talking about Kubernetes specific concepts such as "ConfigMap", "PodList". We treat ConfigMap something special, something different from "config map". Occasionally, we see usage like "config map" in the docs, but we treat them as typos, something to be fixed. |
As another example, "NodePort" is completely different from "node port", because the former has a very specific, very narrow meaning in the Kubernetes context. |
@tengqm Thanks for your replay. It's very tangled for me, I don't have a strong opinion. PS: Happy Mid-Autumn Festival |
@hwdef Can we merge it today? |
So how do we decide, should we remove spaces between words like |
@maciaszczykm |
@tanjunchen |
According to the requirements of the k8s document, some document need to be discussed again, such as DaemonSet, etc. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hwdef, tanjunchen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tanjunchen Good find. If we will be able to do it for all languages then I'd vote for it. |
BTW |
No description provided.