Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Simplified Chinese translation #7416

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

hwdef
Copy link
Member

@hwdef hwdef commented Aug 31, 2022

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 31, 2022
@k8s-ci-robot k8s-ci-robot added language/zh Updates or issues for Chinese translations. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 31, 2022
@hwdef
Copy link
Member Author

hwdef commented Aug 31, 2022

/assign @tengqm @helight @tanjunchen
PTAL

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #7416 (9086340) into master (a4fdb9f) will not change coverage.
The diff coverage is n/a.

❗ Current head 9086340 differs from pull request most recent head a4c64e5. Consider uploading reports for the commit a4c64e5 to get more accurate results

@@           Coverage Diff           @@
##           master    #7416   +/-   ##
=======================================
  Coverage   44.22%   44.22%           
=======================================
  Files          46       46           
  Lines        1282     1282           
  Branches      178      178           
=======================================
  Hits          567      567           
  Misses        677      677           
  Partials       38       38           

i18n/zh-Hans/messages.zh-Hans.xlf Outdated Show resolved Hide resolved
i18n/zh-Hans/messages.zh-Hans.xlf Outdated Show resolved Hide resolved
i18n/zh-Hans/messages.zh-Hans.xlf Outdated Show resolved Hide resolved
i18n/zh-Hans/messages.zh-Hans.xlf Outdated Show resolved Hide resolved
i18n/zh-Hans/messages.zh-Hans.xlf Outdated Show resolved Hide resolved
<context-group purpose="location">
<context context-type="sourcefile">src/app/frontend/resource/workloads/deployment/detail/template.html</context>
<context context-type="linenumber">174</context>
</context-group>
</trans-unit>
<trans-unit id="1257046302587502112" datatype="html">
<source>New Replica Set</source>
<target state="new">New Replica Set</target>
<target>新的 Replica Set</target>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<target>新的 Replica Set</target>
<target>新的 ReplicaSet</target>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不翻译的部分应与上面<source>中的内容保持一致

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

英文的表达是有问题的,翻译的时候可以酌情修正。

i18n/zh-Hans/messages.zh-Hans.xlf Outdated Show resolved Hide resolved
i18n/zh-Hans/messages.zh-Hans.xlf Outdated Show resolved Hide resolved
i18n/zh-Hans/messages.zh-Hans.xlf Outdated Show resolved Hide resolved
i18n/zh-Hans/messages.zh-Hans.xlf Outdated Show resolved Hide resolved
@hwdef
Copy link
Member Author

hwdef commented Sep 1, 2022

@tengqm 感谢你的审核,需要修改的部分我已经修改,其他需要讨论的部分我已回复。请再次审核。

<context-group purpose="location">
<context context-type="sourcefile">src/app/frontend/common/components/securitycontext/template.html</context>
<context context-type="linenumber">54</context>
</context-group>
</trans-unit>
<trans-unit id="3321884531921673789" datatype="html">
<source>Run as User</source>
<target state="new">Run as User</target>
<target>用户身份</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<target>用户身份</target>
<target>以用户身份运行</target>

<context-group purpose="location">
<context context-type="sourcefile">src/app/frontend/common/components/securitycontext/template.html</context>
<context context-type="linenumber">60</context>
</context-group>
</trans-unit>
<trans-unit id="7769329651019167020" datatype="html">
<source>Run as Group</source>
<target state="new">Run as Group</target>
<target>组身份</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<target>组身份</target>
<target>以组身份运行</target>

<context-group purpose="location">
<context context-type="sourcefile">src/app/frontend/common/components/securitycontext/template.html</context>
<context context-type="linenumber">65</context>
</context-group>
</trans-unit>
<trans-unit id="7517495778455112288" datatype="html">
<source>Run as Non-Root</source>
<target state="new">Run as Non-Root</target>
<target>非 Root 身份</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<target> Root 身份</target>
<target>以非 Root 身份运行</target>

@hwdef
Copy link
Member Author

hwdef commented Sep 1, 2022

@ydFu
感谢你的建议,你提到的这几处,是我按照 @tengqm 的建议修改的,我觉得这两种都没问题,或许你们可以商量下采用哪种方式更好。

@hwdef
Copy link
Member Author

hwdef commented Sep 1, 2022

@shu-mutou
Hi, Shu, do you know why dashboard display k8s resource like this
image
Why split up replicaset, cronjobs and other resources, they should be one word, why become two words?

@shu-mutou
Copy link
Contributor

Sorry for late response.

Why split up replicaset, cronjobs and other resources, they should be one word, why become two words?

I don't know. It seems that way from the beginning. But from a UX perspective, I think Replica Sets is a more human readable format. The replicaset is indeed a k8s resource name, often used as is, but for machines, not humans, IMHO.

@maciaszczykm @floreks Do you know why?

@floreks
Copy link
Member

floreks commented Sep 9, 2022

Yes, this is a human readable format for better UX and we want to keep it that way.

@hwdef
Copy link
Member Author

hwdef commented Sep 9, 2022

Yes, this is a human readable format for better UX and we want to keep it that way.

@tengqm I suggest to refer to the opinion of the dashboard maintainer and not modify these words.

@tengqm
Copy link

tengqm commented Sep 10, 2022

Yes, this is a human readable format for better UX and we want to keep it that way.

@tengqm I suggest to refer to the opinion of the dashboard maintainer and not modify these words.

With my SIG docs maintainer's hat on, I don't think we should spell StatefulSet as "stateful set", ConfigMap as "config map", or HorizontalPodAutoscaler as "horizontal pod autoscaler". This has been documented as documentation style here. This is to avoid confusion when talking about Kubernetes specific concepts such as "ConfigMap", "PodList". We treat ConfigMap something special, something different from "config map". Occasionally, we see usage like "config map" in the docs, but we treat them as typos, something to be fixed.

@tengqm
Copy link

tengqm commented Sep 10, 2022

As another example, "NodePort" is completely different from "node port", because the former has a very specific, very narrow meaning in the Kubernetes context.

@hwdef
Copy link
Member Author

hwdef commented Sep 10, 2022

@tengqm Thanks for your replay. It's very tangled for me, I don't have a strong opinion.

PS: Happy Mid-Autumn Festival

@maciaszczykm
Copy link
Member

@hwdef Can we merge it today?

@hwdef
Copy link
Member Author

hwdef commented Sep 16, 2022

@hwdef Can we merge it today?

So how do we decide, should we remove spaces between words like cron jobs?I think we're stuck here.

@maciaszczykm
Copy link
Member

@hwdef We should keep them as @floreks already said.

@hwdef
Copy link
Member Author

hwdef commented Sep 16, 2022

@maciaszczykm
ok.

@hwdef
Copy link
Member Author

hwdef commented Sep 16, 2022

@tanjunchen
Please take a look.

@tanjunchen
Copy link
Member

According to the requirements of the k8s document, some document need to be discussed again, such as DaemonSet, etc.
When we discuss with dashboard en maintainers clearly, we will update the document. I merged it firstly.

@tanjunchen
Copy link
Member

/lgtm
thanks for your contributions.
@hwdef

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hwdef, tanjunchen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f8ca73e into kubernetes:master Sep 16, 2022
@hwdef hwdef deleted the update-zh-hans-translation branch September 16, 2022 14:25
@maciaszczykm
Copy link
Member

@tanjunchen Good find. If we will be able to do it for all languages then I'd vote for it.

@maciaszczykm
Copy link
Member

BTW <Target>...<target> was causing build issues. Fixed it in #7047.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Updates or issues for Chinese translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants