Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update German translation. #7231

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

headcr4sh
Copy link
Contributor

@headcr4sh headcr4sh commented Jul 4, 2022

I went through all state="new" entries and touched some of the already translated entries as well to improve upon wording here and there...

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 4, 2022
@k8s-ci-robot k8s-ci-robot added the language/de Updates or issues for German translations. label Jul 4, 2022
@k8s-ci-robot k8s-ci-robot requested a review from mkorbi July 4, 2022 08:12
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2022
@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #7231 (de90833) into master (4eca08f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7231   +/-   ##
=======================================
  Coverage   44.22%   44.22%           
=======================================
  Files          46       46           
  Lines        1282     1282           
  Branches      178      178           
=======================================
  Hits          567      567           
  Misses        677      677           
  Partials       38       38           

@maciaszczykm
Copy link
Member

@headcr4sh Sorry for long delay! Do you know someone from K8s org that would be able to review it?

@headcr4sh
Copy link
Contributor Author

headcr4sh commented Aug 12, 2022

@headcr4sh Sorry for long delay! Do you know someone from K8s org that would be able to review it?

No worries. ;-)

I am not sure where to look for support from translators.
Maybe someone in the Slack channel #sig-docs-localizations might be able to help out?
(Sorry -- I am not really familiar with how to gather reviewers for translation changes)

@maciaszczykm
Copy link
Member

Maybe someone in the Slack channel #sig-docs-localizations might be able to help out?

@headcr4sh That would be good, can you reach out?

@headcr4sh
Copy link
Contributor Author

Maybe someone in the Slack channel #sig-docs-localizations might be able to help out?

@headcr4sh That would be good, can you reach out?

Sure. Already did that. :)
Let's see if anybody answers my call...

[Quote from my message to Slack #sig-docs-localizations]

Hi there,
we are looking for members of the Kubernetes GitHub organization to check on the updated
German translations of the Kubernetes Dashboard that I have provided.
If you want to help out, check out the PR and raise your hand. 😄

@headcr4sh
Copy link
Contributor Author

I just left the same message from above in Slack channel #kubernetes-docs-de as "double post" to see if a possible translator who is not reading #sig-docs-localization might turn up. :-)

@bene2k1
Copy link
Member

bene2k1 commented Aug 26, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bene2k1, headcr4sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 26a3166 into kubernetes:master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Updates or issues for German translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants