Support custom rules for read-only mode

[korjek]

When dashboard is started with read-only role, CRDs are not shown in UI due to permissions issue.
This PR adds ability to provide custom rules for read-only role

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: korjek / name: Yevgeniy Korin (23efce1, 0761bb7, ee2dcc2)

[k8s-ci-robot]

Welcome @korjek!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[desaintmartin]

Thanks for the contribution!
Wouldn't it be better to add the ability in this case to add in the clusterrole itself the missing permission? I am reluctant to add such deep customization (in the case where someone wants to have its own customized rbacs, it's probably better to do it outside of the chart).

[desaintmartin]

/assign

[korjek]

@desaintmartin sorry for the late reply, it fell out of my radar.

Wouldn't it be better to add the ability in this case to add in the clusterrole itself the missing permission?

Not sure that I got the idea. Could you please explain a bit more?

in the case where someone wants to have its own customized rbacs, it's probably better to do it outside of the chart

If someone uses helm to deploy everything, that would mean (if I got your idea correct) creating a custom in-house chart and using it to create role with custom permissions for k8s dashboard. I don't think this is a good way to go.

[desaintmartin]

@desaintmartin sorry for the late reply, it fell out of my radar.

Wouldn't it be better to add the ability in this case to add in the clusterrole itself the missing permission?

Not sure that I got the idea. Could you please explain a bit more?
Instead of setting a new option and telling users to add CRD permissions in extra RBAC to have a working dashboard, shouldn't it be done by default?

[korjek]

Instead of setting a new option and telling users to add CRD permissions in extra RBAC to have a working dashboard, shouldn't it be done by default?

I don't think it's possible, as every CRD has it's own apiGroup.
So with the PR I proposed we have the next lines in values.yaml to be able to see sparkapplications in k8s dashboard:

    clusterReadOnlyRoleAdditionalRules:
      - apiGroups:
        - apiextensions.k8s.io
        resources:
        - customresourcedefinitions
        verbs:
        - get
        - list
        - watch
      - apiGroups:
        - sparkoperator.k8s.io
        resources:
        - sparkapplications
        - sparkapplications/status
        - scheduledsparkapplication
        - scheduledsparkapplication/status
        verbs:
        - get
        - list
        - watch

[korjek]

@desaintmartin thoughts?

[korjek]

@desaintmartin could we proceed this way? or what other options do we have instead of forking?

[korjek]

@shu-mutou maybe you can help here?

[desaintmartin]

Sorry for the huge delay. Indeed this makes sense for CRDs.

[korjek]

@desaintmartin thank you!
Resolved conflicts

[desaintmartin]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: desaintmartin, korjek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• aio/deploy/helm-chart/kubernetes-dashboard/OWNERS [desaintmartin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment