Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and fix issues with create from view #7007

Merged
merged 3 commits into from
Apr 13, 2022

Conversation

floreks
Copy link
Member

@floreks floreks commented Apr 13, 2022

  • Fixed an issue with unsaved changes dialog showing up when it shouldn't by slightly refactoring current logic
  • Fixed an issue with some API error messages not being translated
  • Moved Namespace option in the Create from form to the always visible options as it was not clear which namespace is selected and will be used to deploy the resource
  • Fixed an issue with Create from file not working
  • Fixed an issue with Preview feature not adding namespace field to resource preview YAML/JSON

Closes #6990

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 13, 2022
@k8s-ci-robot k8s-ci-robot added language/de Updates or issues for German translations. language/fr Updates or issues for French translations. approved Indicates a PR has been approved by an approver from all required OWNERS files. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. labels Apr 13, 2022
@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #7007 (c077c68) into master (f698d98) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7007   +/-   ##
=======================================
  Coverage   41.82%   41.82%           
=======================================
  Files          45       45           
  Lines        1229     1229           
  Branches      161      161           
=======================================
  Hits          514      514           
  Misses        715      715           

@maciaszczykm
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Updates or issues for German translations. language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants