Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(helm): remove local subchart tgz, upgrade helm ci dependencies, add gitignore for subcharts. #6962

Merged
merged 1 commit into from
Apr 5, 2022
Merged

ci(helm): remove local subchart tgz, upgrade helm ci dependencies, add gitignore for subcharts. #6962

merged 1 commit into from
Apr 5, 2022

Conversation

desaintmartin
Copy link
Member

@desaintmartin desaintmartin commented Apr 5, 2022 •
edited
Loading

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 5, 2022
@desaintmartin desaintmartin changed the title ci(helm): remove local subchart tgz, upgrade helm ci dependencies, ad… ci(helm): remove local subchart tgz, upgrade helm ci dependencies, add gitignore for subcharts. Apr 5, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 5, 2022
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 5, 2022
@codecov
Copy link

codecov bot commented Apr 5, 2022 •
edited
Loading

Codecov Report

Merging #6962 (e906f06) into master (80f5b97) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6962   +/-   ##
=======================================
  Coverage   41.65%   41.65%           
=======================================
  Files          45       45           
  Lines        1234     1234           
  Branches      179      179           
=======================================
  Hits          514      514           
  Misses        681      681           
  Partials       39       39

@maciaszczykm
Copy link
Member

/lgtm
/approve

@desaintmartin thank you!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: desaintmartin, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2022
@k8s-ci-robot k8s-ci-robot merged commit 628f9a2 into kubernetes:master Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeefy jeefy Awaiting requested review from jeefy

@shu-mutou shu-mutou Awaiting requested review from shu-mutou

Assignees

@maciaszczykm maciaszczykm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@desaintmartin @maciaszczykm @k8s-ci-robot