Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail to scrape metrics when use https #6901

Merged
merged 2 commits into from
Mar 17, 2022
Merged

fail to scrape metrics when use https #6901

merged 2 commits into from
Mar 17, 2022

Conversation

drunkirishcoder
Copy link
Contributor

If https is used, the service monitor is not properly configured to scrape metrics.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 17, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: drunkirishcoder / name: Daniel Jin (4206273)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 17, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @drunkirishcoder!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 17, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 17, 2022
@drunkirishcoder
Copy link
Contributor Author

/assign @desaintmartin

Copy link
Member

@desaintmartin desaintmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Could you bump a patch version of the chart in Chart.yaml?

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #6901 (0877e09) into master (e429c18) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6901   +/-   ##
=======================================
  Coverage   41.65%   41.65%           
=======================================
  Files          45       45           
  Lines        1234     1234           
  Branches      163      163           
=======================================
  Hits          514      514           
  Misses        720      720           

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2022
@desaintmartin
Copy link
Member

Thanks again!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: desaintmartin, drunkirishcoder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@drunkirishcoder
Copy link
Contributor Author

No problem! Once merged, how soon can a release go out?

@k8s-ci-robot k8s-ci-robot merged commit 9ad4efd into kubernetes:master Mar 17, 2022
@drunkirishcoder drunkirishcoder deleted the patch-1 branch March 19, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants