Pamper pod list view: a few usability fixes #1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bryk
commented
Nov 24, 2016
bryk
commented
- Removed cluster IP colum - it is little useful there
- Made status column ellipsable
- Adjusted default widths and scaling factors for all columns - now age and restarts are small and no grow, others grow as needed
- Made sparklines 80px wide - we don't need anything more for 15 points of data anyway
1. Removed cluster IP colum - it is little useful there 2. Made status column ellipsable 3. Adjusted default widths and scaling factors for all columns - now age and restarts are small and no grow, others grow as needed 4. Made sparklines 80px wide - we don't need anything more for 15 points of data anyway
k8s-ci-robot
added
the
cncf-cla: yes
|
@rf232 Can you review this? |
|
Is:
Was: |
Current coverage is 93.50% (diff: 100%)
|
|
Resolve podcardlist.html, but LGTM |
|
Merged, PTAL |
rf232
approved these changes
Nov 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.