-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new taint key in design doc #985
Conversation
bdd47c6
to
be5f9c2
Compare
cc @k82cn for review |
| |Unknown | NoExecute | node.kubernetes.io/unreachable | | ||
|OutOfDisk |True | NoSchedule | node.kubernetes.io/outOfDisk | | ||
| |False | NoExecute | node.kubernetes.io/not-ready | | ||
| |Unknown | NoExecute | node.alpha.kubernetes.io/unreachable | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not also remove alpha for unreachable
? so we will handle not-ready
and unreachable
in the same way :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should, bad rebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fired up kubernetes/kubernetes#54198 to track this inconsistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
/lgtm , just can not remember why we only change |
be5f9c2
to
c2cc0d5
Compare
Addressed comments.
Not clear for me either ... |
This PR hasn't been active in 30 days. It will be closed in 59 days (Jan 17, 2018). cc @brendandburns @davidopp @k82cn @resouer You can add 'keep-open' label to prevent this from happening, or add a comment to keep it open another 90 days |
/lgtm |
/retest |
/test all [submit-queue is verifying that this PR is safe to merge] |
@davidopp thanks, merge? |
Automatic merge from submit-queue. |
OK. The bot is clever than I expect :) |
Automatic merge from submit-queue. Use new taint key in design doc Part of: kubernetes/kubernetes#51246 ~~**DO NOT MERGE** until kubernetes/kubernetes#51266 is in!~~
Part of: kubernetes/kubernetes#51246
DO NOT MERGE until kubernetes/kubernetes#51266 is in!