Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e-tests: describe pod security admission #6542

Merged
merged 1 commit into from
Mar 25, 2022
Merged

e2e-tests: describe pod security admission #6542

merged 1 commit into from
Mar 25, 2022

Conversation

s-urbaniak
Copy link
Contributor

This describes pod security admission configuration for e2e tests.

/cc @liggitt @deads2k

/cc @kubernetes/sig-testing for verification if this is the correct place to describe the e2e test framework helpers.

xref kubernetes/kubernetes#106454

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/developer-guide Issues or PRs related to the developer guide sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 16, 2022
@s-urbaniak s-urbaniak mentioned this pull request Mar 16, 2022
Merged
3 tasks
@s-urbaniak
Copy link
Contributor Author

/cc @stlaz

@k8s-ci-robot
Copy link
Contributor

@s-urbaniak: GitHub didn't allow me to request PR reviews from the following users: stlaz.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @stlaz

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liggitt
Copy link
Member

liggitt commented Mar 25, 2022

/lgtm

needs approval from sig-test leads

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2022
@stevekuznetsov
Copy link
Contributor

/lgtm

@stevekuznetsov
Copy link
Contributor

Whoops, forgot /lgtm did not imply /approve any longer.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: s-urbaniak, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2022
@k8s-ci-robot k8s-ci-robot merged commit dbb243f into kubernetes:master Mar 25, 2022
@s-urbaniak s-urbaniak deleted the pod-security-admission branch March 25, 2022 15:36
@stlaz stlaz mentioned this pull request Apr 1, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stlaz stlaz stlaz left review comments

@deads2k deads2k Awaiting requested review from deads2k

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

@stevekuznetsov stevekuznetsov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/developer-guide Issues or PRs related to the developer guide cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@s-urbaniak @k8s-ci-robot @liggitt @stevekuznetsov @stlaz