Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cutting down readme for contributor-site #4456

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

vishakhanihore
Copy link
Contributor

@vishakhanihore vishakhanihore commented Jan 28, 2020

Which issue(s) this PR fixes:

Refers #4444
Refers kubernetes/contributor-site#86

  • Breaking down readME to :

    • First Contribution
    • Contributing
  • Adjusting weights to accomodate this change

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 28, 2020
@k8s-ci-robot k8s-ci-robot added area/contributor-guide Issues or PRs related to the contributor guide sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Jan 28, 2020
@vishakhanihore
Copy link
Contributor Author

/assign @guineveresaenger
/assign @mrbobbytables
/cc @parispittman

Copy link
Member

@mrbobbytables mrbobbytables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to adjust the weights and such of content.
Eventually the readme should direct people to all the other content in the in the contributor guide.

contributors/guide/README.md Outdated Show resolved Hide resolved
contributors/guide/README.md Outdated Show resolved Hide resolved
contributors/guide/README.md Outdated Show resolved Hide resolved
contributors/guide/contributing.md Show resolved Hide resolved
contributors/guide/first-contribution.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 28, 2020
@vishakhanihore
Copy link
Contributor Author

@mrbobbytables All the requested changes have been addressed. Please take a look!

@mrbobbytables
Copy link
Member

Thanks!
I'll wait for a few more folk to chime in :)
/assign @castrojo

@parispittman
Copy link
Contributor

i would title the before-get-started.md as getting-started.md. i see some other nits with the actual content but i can raise those later on post this structure change. thank you!

@mrbobbytables
Copy link
Member

i would title the before-get-started.md as getting-started.md. i see some other nits with the actual content but i can raise those later on post this structure change. thank you!

Didn't catch that and I agree. the slug will need to be updated to match the file-name, but it should still be ordered right in the menu 👍

@vishakhanihore
Copy link
Contributor Author

@parispittman @mrbobbytables Made the changes, Please check 😅

contributors/guide/README.md Outdated Show resolved Hide resolved
contributors/guide/get-started.md Outdated Show resolved Hide resolved
Copy link
Member

@mrbobbytables mrbobbytables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small little changes 👍

@vishakhanihore
Copy link
Contributor Author

@mrbobbytables @parispittman Done the changes. Have a look

@mrbobbytables
Copy link
Member

/approve
Thanks for putting up with all the back and forth @vishakhanihore ^^:;;

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrbobbytables, vishakhanihore

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2020
@markjacksonfishing
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 30, 2020
@k8s-ci-robot k8s-ci-robot merged commit a733230 into kubernetes:master Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/contributor-guide Issues or PRs related to the contributor guide cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants