-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cutting down readme for contributor-site #4456
Conversation
/assign @guineveresaenger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll want to adjust the weights and such of content.
Eventually the readme should direct people to all the other content in the in the contributor guide.
@mrbobbytables All the requested changes have been addressed. Please take a look! |
Thanks! |
i would title the before-get-started.md as getting-started.md. i see some other nits with the actual content but i can raise those later on post this structure change. thank you! |
Didn't catch that and I agree. the slug will need to be updated to match the file-name, but it should still be ordered right in the menu 👍 |
@parispittman @mrbobbytables Made the changes, Please check 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small little changes 👍
@mrbobbytables @parispittman Done the changes. Have a look |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrbobbytables, vishakhanihore The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Which issue(s) this PR fixes:
Refers #4444
Refers kubernetes/contributor-site#86
Breaking down readME to :
Adjusting weights to accomodate this change