Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Protection Working Group #4301

Merged
merged 3 commits into from
Jan 7, 2020

Conversation

xing-yang
Copy link
Contributor

@xing-yang xing-yang commented Dec 10, 2019

This PR proposes to form a Data Protection Working Group. This is a cross SIG collaboration between SIG-Apps and SIG-Storage.

Discussed at SIG-Apps and SIG-Storage meetings and proposed in the mailing list:
https://groups.google.com/forum/#!topic/kubernetes-dev/0ZWLfML3uS0

committee/steering
Approvers: @saad-ali @prydonius

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 10, 2019
@xing-yang
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2019
@nikhita
Copy link
Member

nikhita commented Dec 10, 2019

/committee steering

cc @kubernetes/steering-committee

@k8s-ci-robot k8s-ci-robot added the committee/steering Denotes an issue or PR intended to be handled by the steering committee. label Dec 10, 2019
Copy link

@prydonius prydonius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

charter lgtm

wg-data-protection/charter.md Outdated Show resolved Hide resolved
@yuxiangqian
Copy link

cc @jingxu97

@yuxiangqian
Copy link

cc @alarge

@xing-yang
Copy link
Contributor Author

cc @liyinan926

wg-data-protection/charter.md Outdated Show resolved Hide resolved
wg-data-protection/charter.md Outdated Show resolved Hide resolved
wg-data-protection/charter.md Show resolved Hide resolved
@spiffxp
Copy link
Member

spiffxp commented Dec 11, 2019

LGTM from steering member, need three more

sigs.yaml Show resolved Hide resolved
sigs.yaml Show resolved Hide resolved
sigs.yaml Show resolved Hide resolved
wg-data-protection/charter.md Outdated Show resolved Hide resolved
wg-data-protection/charter.md Outdated Show resolved Hide resolved
@dims
Copy link
Member

dims commented Dec 12, 2019

LGTM from me (any nits from me are not blocking)

@timothysc
Copy link
Member

/assign @timothysc

@xing-yang
Copy link
Contributor Author

I am okay with SIG Auth not being explicitly listed as a stakeholder here (though I would like opinions from the other tech leads). We try to avoid being SIG "Security" since everything has some security aspect.

Thanks @enj. Either way I'm open to suggestions from SIG Auth leads.

@xing-yang
Copy link
Contributor Author

Talked to @deads2k and he thinks that SIG-Auth does not need to be an endorsing SIG, but the WG will need to engage to some degree with SIG-Auth.

So I removed SIG Auth as an endorsing SIG and stated that we will consult SIG Auth from security aspects.

@tallclair
Copy link
Member

It seems like the main focus of this working group is around backup and restore (as @mikedanese mentioned, I was expecting more of a policy & compliance angle). If that is indeed the focus, can you explain why this needs to be a working group, and isn't just a subproject of SIG-Storage?

If the policy aspects are within scope, then you should also sync up with the policy working group and CNCF SIG-Security, which are looking at similar issues.

@xing-yang
Copy link
Contributor Author

xing-yang commented Dec 16, 2019

It seems like the main focus of this working group is around backup and restore (as @mikedanese mentioned, I was expecting more of a policy & compliance angle). If that is indeed the focus, can you explain why this needs to be a working group, and isn't just a subproject of SIG-Storage?

If the policy aspects are within scope, then you should also sync up with the policy working group and CNCF SIG-Security, which are looking at similar issues.

Hi @tallclair, this WG is looking at things from SIG-Apps angle as well, not just within SIG-Storage scope.

@nrb
Copy link

nrb commented Dec 17, 2019

If that is indeed the focus, can you explain why this needs to be a working group, and isn't just a subproject of SIG-Storage?

@tallclair From my conversations around this, I believe the reasoning includes (but isn't limited to) the following topics, which I think this document should mention explicitly:

  • How are application representations inside the Kubernetes API server/etcd backed up and restored? I work on Velero, which has one approach to this, but there's also the Stateful Application Data Management API KEP
  • How is application quiescing handled before and after snapshots? This is something sig-storage has deferred to sig-apps on as I understand, with work such as ExecutionHooks

@mikedanese
Copy link
Member

I am okay with SIG Auth not being explicitly listed as a stakeholder here (though I would like opinions from the other tech leads). We try to avoid being SIG "Security" since everything has some security aspect.

I agree with this assessment.

Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, otherwise
/lgtm

wg-data-protection/charter.md Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 6, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2020
@xing-yang
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2020
@xing-yang
Copy link
Contributor Author

Rebased.

@dims
Copy link
Member

dims commented Jan 7, 2020

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2020
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, timothysc, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1cdddfc into kubernetes:master Jan 7, 2020
@derekwaynecarr
Copy link
Member

i had been out of office, but for posterity, this is lgtm

/lgtm

@xing-yang
Copy link
Contributor Author

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.