Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update labels for keps/ dir #2677

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Update labels for keps/ dir #2677

merged 1 commit into from
Oct 2, 2018

Conversation

justaugustus
Copy link
Member

@justaugustus
Update labels for keps/ dir
1f684bc 
Signed-off-by: Stephen Augustus <[email protected]>
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/pm sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 17, 2018
@justaugustus justaugustus mentioned this pull request Sep 18, 2018
Merged
@justaugustus
Copy link
Member Author

This is ready to merge, now that the label exists.

/hold cancel
/kind kep
/assign @idvoretskyi @calebamiles @jdumars

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 2, 2018
@jdumars
Copy link
Member

jdumars commented Oct 2, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2018
@cblecker
Copy link
Member

cblecker commented Oct 2, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2018
@k8s-ci-robot k8s-ci-robot merged commit ea516c1 into kubernetes:master Oct 2, 2018
justaugustus pushed a commit to justaugustus/community that referenced this pull request Dec 1, 2018
@k8s-ci-robot
Merge pull request kubernetes#2677 from justaugustus/kep-labels
9fe7946 
Update labels for keps/ dir
@justaugustus
Copy link
Member Author

/remove-sig pm
/sig architecture
/area enhancements

@k8s-ci-robot k8s-ci-robot added area/enhancements Issues or PRs related to the Enhancements subproject and removed sig/pm labels Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgrant0607 bgrant0607 Awaiting requested review from bgrant0607

@jdumars jdumars Awaiting requested review from jdumars

Assignees

@idvoretskyi idvoretskyi

@calebamiles calebamiles

@jdumars jdumars

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/enhancements Issues or PRs related to the Enhancements subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@justaugustus @jdumars @cblecker @k8s-ci-robot @idvoretskyi @calebamiles