Skip to content

Commit

Permalink
Merge pull request #1778 from cblecker/godeps-owners
Browse files Browse the repository at this point in the history
Add section on reviewing/approving godeps
  • Loading branch information
k8s-ci-robot authored Feb 20, 2018
2 parents 25b16c9 + 0b774ed commit 94a104d
Showing 1 changed file with 22 additions and 0 deletions.
22 changes: 22 additions & 0 deletions contributors/devel/godep.md
Original file line number Diff line number Diff line change
Expand Up @@ -187,3 +187,25 @@ paths to coexist in the same git repo.

The verifiers, including `hack/verify-godeps.sh` *must* pass for every pull
request.

## Reviewing and approving dependency changes

Particular attention to detail should be exercised when reviewing and approving
PRs that add/remove/update dependencies. Importing a new dependency should bring
a certain degree of value as there is a maintenance overhead for maintaining
dependencies into the future.

When importing a new dependency, be sure to keep an eye out for the following:
- Is the dependency maintained?
- Does the dependency bring value to the project? Could this be done without
adding a new dependency?
- Is the target dependency the original source, or a fork?
- Is there already a dependency in the project that does something similar?
- Does the dependency have a license that is compatible with the Kubernetes
project?

All new dependency licenses should be reviewed by either Tim Hockin (@thockin)
or the Steering Committee (@kubernetes/steering-committee) to ensure that they
are compatible with the Kubernetes project license. It is also important to note
and flag if a license has changed when updating a dependency, so that these can
also be reviewed.

0 comments on commit 94a104d

Please sign in to comment.