Update openstack-cinder-csi helm chart for multi cloud support #2681
+69
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Hello, this PR modifies the openstack-cinder-csi helm chart to allow to use it with the multi cloud feature: #2551
It fixes two problems that were preventing to use the chart with multi cloud:
extraArgs
on thecinder-csi-plugin
containers of the deployment and the daemonset. It wasn't possible with the current version. Now you can, like this:You still need to create the second daemonset manually, but at least you can use the chart. If this PR is accepted, I'll work on a new one to allow the creation of the second daemonset.
resizer
and thesnapshotter
, you will need them to be able to read the secrets you defined in the storage class' annotations in order to determine which cloud to address. This was hardcoded in controllerplugin-rbac.yaml, now you can specify it like this:I also moved the comments from controllerplugin-rbac.yaml to the values file.
I added these info to the multi-region-clouds.md documentation file.