Skip to content

Update numerous toolchain components.#110

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
pjh:update-toolchain
Oct 17, 2019
Merged

Update numerous toolchain components.#110
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
pjh:update-toolchain

Conversation

@pjh
Copy link
Copy Markdown
Contributor

@pjh pjh commented Oct 17, 2019

These changes fix a build error currently at HEAD and are also needed to prepare for building gke-exec-auth-plugin for Windows.

Updates:

  • go toolchain to 1.13
  • rules_go to v0.20.0
  • gazelle to v0.19.0
  • rules_docker to v0.11.0

io_bazel_rules_go needs updating for bazel-contrib/rules_go#2118 (bazel-contrib/rules_go#1240).

bazel_gazelle and go_sdk need updating for compatibility with vendor/ targets that will be updated.

rules_docker needs updating to eliminate failures when running bazel build ... at HEAD. The corresponding update to the go toolchain is needed to completely eliminate the failures. For some more details see this gist.

With these changes and a gcloud auth login, running bazel build ... to build the entire repository succeeds.

NOTES FOR REVIEWERS:

  • When updating rules_docker I had to add a new call to container_deps() as suggested here. There may be additional recommended changes as described in the rules_docker Setup doc, but I did not review that carefully.
  • I did not test these changes other than by building the entire repository - please advise if I should run any manual testing.

These changes fix a build error currently at HEAD and are also needed to
prepare for building gke-exec-auth-plugin for Windows.

Updates:
  - go toolchain to 1.13
  - rules_go to v0.20.0
  - gazelle to v0.19.0
  - rules_docker to v0.11.0

io_bazel_rules_go needs updating for
bazel-contrib/rules_go#2118
(bazel-contrib/rules_go#1240).

bazel_gazelle and go_sdk need updating for compatibility with updated
vendor/ targets.

rules_docker needs updating to eliminate failures when running `bazel
build ...` at HEAD. The corresponding update to the go toolchain is
needed to completely eliminate the failures. For some more details see:
https://gist.github.com/pjh/3e409e8d73dad63782b333c6535696de
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @pjh!

It looks like this is your first PR to kubernetes/cloud-provider-gcp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-gcp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 17, 2019
@pjh
Copy link
Copy Markdown
Contributor Author

pjh commented Oct 17, 2019

/assign awly

@pjh
Copy link
Copy Markdown
Contributor Author

pjh commented Oct 17, 2019

cc @yliaog

@awly
Copy link
Copy Markdown
Contributor

awly commented Oct 17, 2019

LGTM, does bazel test ... succeed too?

@pjh
Copy link
Copy Markdown
Contributor Author

pjh commented Oct 17, 2019

Why didn't I think of that? Yes, bazel test ... succeeds: https://gist.github.com/pjh/7458d27fa98772fa9708813ad0c8f7e6

@awly
Copy link
Copy Markdown
Contributor

awly commented Oct 17, 2019

Thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit af10466 into kubernetes:master Oct 17, 2019
@pjh
Copy link
Copy Markdown
Contributor Author

pjh commented Oct 17, 2019

I cloned a fresh cloud-provider-gcp repository and the bazel build + test passed for me there, hopefully this PR will have no other side effects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants