Update numerous toolchain components.#110
Conversation
These changes fix a build error currently at HEAD and are also needed to prepare for building gke-exec-auth-plugin for Windows. Updates: - go toolchain to 1.13 - rules_go to v0.20.0 - gazelle to v0.19.0 - rules_docker to v0.11.0 io_bazel_rules_go needs updating for bazel-contrib/rules_go#2118 (bazel-contrib/rules_go#1240). bazel_gazelle and go_sdk need updating for compatibility with updated vendor/ targets. rules_docker needs updating to eliminate failures when running `bazel build ...` at HEAD. The corresponding update to the go toolchain is needed to completely eliminate the failures. For some more details see: https://gist.github.com/pjh/3e409e8d73dad63782b333c6535696de
|
Welcome @pjh! |
|
/assign awly |
|
cc @yliaog |
|
LGTM, does |
|
Why didn't I think of that? Yes, |
|
Thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awly The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I cloned a fresh cloud-provider-gcp repository and the bazel build + test passed for me there, hopefully this PR will have no other side effects. |
These changes fix a build error currently at HEAD and are also needed to prepare for building gke-exec-auth-plugin for Windows.
Updates:
io_bazel_rules_go needs updating for bazel-contrib/rules_go#2118 (bazel-contrib/rules_go#1240).
bazel_gazelle and go_sdk need updating for compatibility with vendor/ targets that will be updated.
rules_docker needs updating to eliminate failures when running
bazel build ...at HEAD. The corresponding update to the go toolchain is needed to completely eliminate the failures. For some more details see this gist.With these changes and a
gcloud auth login, runningbazel build ...to build the entire repository succeeds.NOTES FOR REVIEWERS:
container_deps()as suggested here. There may be additional recommended changes as described in the rules_docker Setup doc, but I did not review that carefully.