Skip to content

feat(ecr-cred-provider): support public dualstack endpoints#1332

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
mselim00:dualstack-public
Feb 16, 2026
Merged

feat(ecr-cred-provider): support public dualstack endpoints#1332
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
mselim00:dualstack-public

Conversation

@mselim00
Copy link
Copy Markdown
Contributor

@mselim00 mselim00 commented Jan 23, 2026

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR supports getting an authorization token for credential requests involving ECR's dualstack endpoint. This would enable authenticated pulls using ipv6, and help reduce image pull throttling for users in that situation.

Which issue(s) this PR fixes:

Related to awslabs/amazon-eks-ami#2592

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Support authentication for ECR public dual-stack endpoints

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 23, 2026
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 23, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @mselim00!

It looks like this is your first PR to kubernetes/cloud-provider-aws 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/cloud-provider-aws has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 23, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @mselim00. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 23, 2026
@kmala
Copy link
Copy Markdown
Member

kmala commented Jan 23, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 23, 2026
@kmala
Copy link
Copy Markdown
Member

kmala commented Jan 23, 2026

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 23, 2026
@kmala
Copy link
Copy Markdown
Member

kmala commented Jan 26, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2026
@kmala
Copy link
Copy Markdown
Member

kmala commented Feb 16, 2026

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kmala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added a commit that referenced this pull request Mar 4, 2026
…-upstream-release-1.29

Automated cherry pick of #1332: feat(ecr-cred-provider): support public dualstack endpoints
k8s-ci-robot added a commit that referenced this pull request Mar 4, 2026
…-upstream-release-1.30

Automated cherry pick of #1332: feat(ecr-cred-provider): support public dualstack endpoints
k8s-ci-robot added a commit that referenced this pull request Mar 4, 2026
…-upstream-release-1.32

Automated cherry pick of #1332: feat(ecr-cred-provider): support public dualstack endpoints
k8s-ci-robot added a commit that referenced this pull request Mar 4, 2026
…-upstream-release-1.31

Automated cherry pick of #1332: feat(ecr-cred-provider): support public dualstack endpoints
k8s-ci-robot added a commit that referenced this pull request Mar 4, 2026
…-upstream-release-1.33

Automated cherry pick of #1332: feat(ecr-cred-provider): support public dualstack endpoints
k8s-ci-robot added a commit that referenced this pull request Mar 4, 2026
…-upstream-release-1.35

Automated cherry pick of #1332: feat(ecr-cred-provider): support public dualstack endpoints
k8s-ci-robot added a commit that referenced this pull request Mar 4, 2026
…-upstream-release-1.34

Automated cherry pick of #1332: feat(ecr-cred-provider): support public dualstack endpoints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants