CPU startup boost: add tests #8828
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/L
|
/cc soltysh |
kamarabbas99
changed the title
kamarabbas99
force-pushed
the
experimental-cpu-boost-v2
branch
from
9cbd887 to
1c2f5c0
Compare
|
/assign @soltysh |
| Type StartupBoostType `json:"type" protobuf:"bytes,1,opt,name=type"` | ||
| // factor specifies the factor to apply to the resource request. | ||
| // This field is to be used only when Type is "Factor". | ||
| // This field is required when Type is "Factor". |
There was a problem hiding this comment.
The schema sets this to +optional. How are we going to inforce this conditional requirement?
There was a problem hiding this comment.
It may be best to rather review #8813, this PR is just addressing comments made in that PR, and it's missing lots of context. (note that this is a PR into a feature branch)
There was a problem hiding this comment.
We will error out in the handler, which should be then exposed to the user that the object is miconfigured. Sadly we can't express that condition in through annotations.
|
/retitle CPU startup boost: add tests |
k8s-ci-robot
changed the title
k8s-ci-robot
added
the
lgtm
|
makes sense. |
| Type StartupBoostType `json:"type" protobuf:"bytes,1,opt,name=type"` | ||
| // factor specifies the factor to apply to the resource request. | ||
| // This field is to be used only when Type is "Factor". | ||
| // This field is required when Type is "Factor". |
There was a problem hiding this comment.
We will error out in the handler, which should be then exposed to the user that the object is miconfigured. Sadly we can't express that condition in through annotations.
|
I'm manually adding the approved label here, since this PR is into a feature branch, and review can take place on #8813 |
adrianmoisey
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: kamarabbas99, omerap12, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
merged commit d7c901f
into
kubernetes:experimental-cpu-boost-v2
6 participants
This is to address comments in #8813
Does this PR introduce a user-facing change?