-
Notifications
You must be signed in to change notification settings - Fork 4.2k
[cluster-autoscaler-1.34] Add peer fields to replace inlined Kubernetes API fields #8686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cluster-autoscaler-1.34] Add peer fields to replace inlined Kubernetes API fields #8686
Conversation
|
/test pull-cluster-autoscaler-e2e-azure-1.34 |
|
@jackfrancis: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@liggitt when this lands in the 1.34 branch we can do this:
cc @towca |
|
/test pull-cluster-autoscaler-e2e-azure-1-34 |
|
/assign @towca |
|
@towca reminder that we need to land this in 1.34 branch (and cut a patch release) before we prep for the breaking change that will be introduced in 1.35 |
|
Sorry for missing this, LGTM! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, towca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3f94cc3
into
kubernetes:cluster-autoscaler-release-1.34
What type of PR is this?
/kind api-change
What this PR does / why we need it:
This is a manual cherry-pick of #8660.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: