Commits on Mar 22, 2023

1. feat: check only controller ref to decide if a pod is replicated …

   Signed-off-by: vadasambar <[email protected]>
   (cherry picked from commit 144a64a)
   
   fix: set `replicated` to true if controller ref is set to `true`
   - forgot to add this in the last commit
   
   Signed-off-by: vadasambar <[email protected]>
   (cherry picked from commit f8f4582)
   
   fix: remove `checkReferences`
   - not needed anymore
   Signed-off-by: vadasambar <[email protected]>
   
   (cherry picked from commit 5df6e31)
   
   test(drain): add test for custom controller pod
   Signed-off-by: vadasambar <[email protected]>
   
   feat: add flag to allow scale down on custom controller pods
   - set to `false` by default
   - `false` will be set to `true` by default in the future
   - right now, we want to ensure backwards compatibility and make the feature available if the flag is explicitly set to `true`
   - TODO: this code might need some unit tests. Look into adding unit tests.
   Signed-off-by: vadasambar <[email protected]>
   
   fix: remove `at` symbol in prefix of `vadasambar`
   - to keep it consistent with previous such mentions in the code
   Signed-off-by: vadasambar <[email protected]>
   
   test(utils): run all drain tests twice
   - once for  `allowScaleDownOnCustomControllerOwnedPods=false`
   - and once for `allowScaleDownOnCustomControllerOwnedPods=true`
   Signed-off-by: vadasambar <[email protected]>
   
   docs(utils): add description for `testOpts` struct
   Signed-off-by: vadasambar <[email protected]>
   
   docs: update FAQ with info about `allow-scale-down-on-custom-controller-owned-pods` flag
   Signed-off-by: vadasambar <[email protected]>
   
   refactor: rename `allow-scale-down-on-custom-controller-owned-pods` -> `skip-nodes-with-custom-controller-pods`
   Signed-off-by: vadasambar <[email protected]>
   
   refactor: rename `allowScaleDownOnCustomControllerOwnedPods` -> `skipNodesWithCustomControllerPods`
   Signed-off-by: vadasambar <[email protected]>
   
   test(utils/drain): fix failing tests
   - refactor code to add cusom controller pod test
   Signed-off-by: vadasambar <[email protected]>
   
   refactor: fix long code comments
   - clean-up print statements
   Signed-off-by: vadasambar <[email protected]>
   
   refactor: move `expectFatal` right above where it is used
   - makes the code easier to read
   Signed-off-by: vadasambar <[email protected]>
   
   refactor: fix code comment wording
   Signed-off-by: vadasambar <[email protected]>
   
   refactor: address PR comments
   - abstract legacy code to check for replicated pods into a separate function so that it's easier to remove in the future
   - fix param info in the FAQ.md
   - simplify tests and remove the global variable used in the tests
   - rename `--skip-nodes-with-custom-controller-pods` -> `--scale-down-nodes-with-custom-controller-pods`
   Signed-off-by: vadasambar <[email protected]>
   
   refactor: rename flag `--scale-down-nodes-with-custom-controller-pods` -> `--skip-nodes-with-custom-controller-pods`
   - refactor tests
   Signed-off-by: vadasambar <[email protected]>
   
   docs: update flag info
   Signed-off-by: vadasambar <[email protected]>
   
   fix: forgot to change flag name on a line in the code
   Signed-off-by: vadasambar <[email protected]>
   
   refactor: use `ControllerRef()` directly instead of `controllerRef`
   - we don't need an extra variable
   Signed-off-by: vadasambar <[email protected]>
   
   refactor: create tests consolidated test cases
   - from looping over and tweaking shared test cases
   - so that we don't have to duplicate shared test cases
   Signed-off-by: vadasambar <[email protected]>
   
   refactor: append test flag to shared test description
   - so that the failed test is easy to identify
   - shallow copy tests and add comments so that others do the same
   Signed-off-by: vadasambar <[email protected]>

   

   vadasambar committed Mar 22, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for ff6fe58
   • Browse repository at this point

   Copy the full SHA

   ff6fe58 View commit details

   Browse the repository at this point in the history