-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Closed
Labels
area/cluster-autoscalerarea/provider/azureIssues or PRs related to azure providerIssues or PRs related to azure providerkind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.
Description
The recent Azure cherry-picks to 1.19 and 1.20 (#4356, #4355) broke the Cluster Autoscaler build. It wasn't caught by CI because Github Actions hadn't been backported to 1.19 and 1.20. I tried fixing it, and there are 2 issues:
- Undefined
FakeNodeReasonAnnotationandFakeNodeUnregistered. I think backporting annotate fakeNodes so that cloudprovider implementations can identify them #4119 should solve this. - Undefined
manager.RegisterNodeGroup. This method replacedmanager.RegisterAsgin a large PR cleanup: refactor Azure cache and remove redundant API calls #3717. I tried replacingRegisterNodeGroupwithRegisterAsgin the code manually, but the test that uses it still doesn't pass.
Github Actions are now running on 1.20 and 1.19.
Please fix ASAP.
Metadata
Metadata
Assignees
Labels
area/cluster-autoscalerarea/provider/azureIssues or PRs related to azure providerIssues or PRs related to azure providerkind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.