Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): allow gmsa to be made more HA #87

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

acobaugh
Copy link
Contributor

This PR allows gmsa to be made more HA when installed via the chart. Since the webhook prevents pod creation at the k8s API level, it's critical that gmsa is able to be made more HA.

  • Use nodeSelector instead of podAffinity to place pods on linux nodes, to allow consumers of the chart greater freedom when setting affinity
  • Expose replicas via replicaCount
  • Optionally create a PodDisruptionBudget
  • Expose affinity to allow further pod placement customization

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 13, 2022
@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Sep 13, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @acobaugh!

It looks like this is your first PR to kubernetes-sigs/windows-gmsa 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/windows-gmsa has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 13, 2022
@jsturtevant
Copy link
Contributor

/lgtm

These looks like great improvements to me! Thanks @acobaugh!

@marosset will we be able to generate the chart and update the index in a seperate PR or should we do it here?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2022
@marosset
Copy link
Contributor

/lgtm

These looks like great improvements to me! Thanks @acobaugh!

@marosset will we be able to generate the chart and update the index in a seperate PR or should we do it here?

Let's do it here.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2022
@acobaugh
Copy link
Contributor Author

/lgtm
These looks like great improvements to me! Thanks @acobaugh!
@marosset will we be able to generate the chart and update the index in a seperate PR or should we do it here?

Let's do it here.

Done, I think!

@marosset
Copy link
Contributor

/lgtm
Will approve after tests run.

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2022
@marosset
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acobaugh, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit 7001578 into kubernetes-sigs:master Sep 14, 2022
@jsturtevant jsturtevant mentioned this pull request Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants